From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 4/5] build: initialize stack variables to zero by default
Date: Wed, 15 Jan 2025 06:21:55 +0100 [thread overview]
Message-ID: <20250115052155.GD28609@lst.de> (raw)
In-Reply-To: <173689081941.3476119.6143322419702468919.stgit@frogsfrogsfrogs>
On Tue, Jan 14, 2025 at 01:41:25PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Newer versions of gcc and clang can include the ability to zero stack
> variables by default. Let's enable it so that we (a) reduce the risk of
> writing stack contents to disk somewhere and (b) try to reduce
> unpredictable program behavior based on random stack contents. The
> kernel added this 6 years ago, so I think it's mature enough for
> xfsprogs.
Hmm, this tends to paper of bugs quite badly. But I guess we'd better
paper over bugs in the same way as the kernel code.
Reluctantly-Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-01-15 5:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 21:40 [PATCHSET] xfsprogs: more random bug fixes Darrick J. Wong
2025-01-14 21:40 ` [PATCH 1/5] xfs_db: improve error message when unknown btree type given to btheight Darrick J. Wong
2025-01-15 5:19 ` Christoph Hellwig
2025-01-14 21:40 ` [PATCH 2/5] mkfs: fix parsing of value-less -d/-l concurrency cli option Darrick J. Wong
2025-01-15 5:20 ` Christoph Hellwig
2025-01-14 21:41 ` [PATCH 3/5] m4: fix statx override selection if /usr/include doesn't define it Darrick J. Wong
2025-01-15 5:20 ` Christoph Hellwig
2025-01-14 21:41 ` [PATCH 4/5] build: initialize stack variables to zero by default Darrick J. Wong
2025-01-15 5:21 ` Christoph Hellwig [this message]
2025-01-15 5:26 ` Darrick J. Wong
2025-01-14 21:41 ` [PATCH 5/5] mkfs: allow sizing realtime allocation groups for concurrency Darrick J. Wong
2025-01-15 5:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115052155.GD28609@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox