From: cem@kernel.org
To: linux-xfs@vger.kernel.org
Cc: cem@kernel.org
Subject: [PATCH] libxfs: Remove pointless crc flag check from xfs_agfl_verify
Date: Thu, 16 Jan 2025 17:32:56 +0100 [thread overview]
Message-ID: <20250116163304.492079-1-cem@kernel.org> (raw)
From: Carlos Maiolino <cem@kernel.org>
Just a small clean up.
xfs_agfl_verify() is only called from xfs_agfl_{read,write}_verify()
helpers.
Both of them already check if crc is enabled, there seems to be no
reason for checking for it again.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
fs/xfs/libxfs/xfs_alloc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 3d33e17f2e5c..619e6d6570f8 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -787,9 +787,6 @@ xfs_agfl_verify(
__be32 *agfl_bno = xfs_buf_to_agfl_bno(bp);
int i;
- if (!xfs_has_crc(mp))
- return NULL;
-
if (!xfs_verify_magic(bp, agfl->agfl_magicnum))
return __this_address;
if (!uuid_equal(&agfl->agfl_uuid, &mp->m_sb.sb_meta_uuid))
--
2.47.1
next reply other threads:[~2025-01-16 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 16:32 cem [this message]
2025-01-16 16:53 ` [PATCH] libxfs: Remove pointless crc flag check from xfs_agfl_verify Darrick J. Wong
2025-01-16 17:28 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116163304.492079-1-cem@kernel.org \
--to=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox