From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrey Albershteyn <aalbersh@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_scrub_all.timer: don't run if /var/lib/xfsprogs is readonly
Date: Mon, 27 Jan 2025 09:57:51 +0100 [thread overview]
Message-ID: <20250127085751.GA22719@lst.de> (raw)
In-Reply-To: <20250122193437.GY3557553@frogsfrogsfrogs>
On Wed, Jan 22, 2025 at 11:34:37AM -0800, Darrick J. Wong wrote:
> The particular place that I noticed this was on my fstests fleet, where
> the root filesystem is an ro nfs4 export. I forgot to configure an
> overlayfs for /var/lib/xfsprogs, so when I upgraded it to xfsprogs 6.12
> and left the VMs running on a Sunday morning, they tried to start
> xfs_scrub_all and failed. Then the monitoring systems emailed me about
> that, and I got 150 emails. :(
>
> This /should/ be a pretty uncommon situation since (AFAICT) most
> readonly-root systems set up a writable (and possibly volatile)
> /var/lib, but I thought I should just turn off the timer if it's going
> to fail anyway.
Can you write this up in a comment in the systemd unit file?
With that the patch looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-01-27 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 2:00 [PATCH] xfs_scrub_all.timer: don't run if /var/lib/xfsprogs is readonly Darrick J. Wong
2025-01-22 6:02 ` Christoph Hellwig
2025-01-22 7:18 ` Darrick J. Wong
2025-01-22 7:22 ` Christoph Hellwig
2025-01-22 19:34 ` Darrick J. Wong
2025-01-27 8:57 ` Christoph Hellwig [this message]
2025-01-27 16:03 ` Darrick J. Wong
2025-01-27 21:36 ` [PATCH v2] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127085751.GA22719@lst.de \
--to=hch@lst.de \
--cc=aalbersh@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox