public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: aalbersh@redhat.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH] mkfs: use a default sector size that is also suitable for the rtdev
Date: Mon, 27 Jan 2025 14:54:03 +0100	[thread overview]
Message-ID: <20250127135403.525965-1-hch@lst.de> (raw)

When creating a filesytem where the data device has a sector size
smalle than that of the RT device without further options, mkfs
currently fails with:

mkfs.xfs: error - cannot set blocksize 512 on block device $RTDEV: Invalid argument

This is because XFS sets the sector size based on logical block size
of the data device, but not that of the RT device.  Change the code
so that is uses the larger of the two values.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mkfs/xfs_mkfs.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 6cc7e6439ca1..0627af81da37 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -2368,7 +2368,9 @@ validate_sectorsize(
 		 * advertised sector size of the device.  We use the physical
 		 * sector size unless the requested block size is smaller
 		 * than that, then we can use logical, but warn about the
-		 * inefficiency.
+		 * inefficiency.  If the file system has a RT device, the
+		 * sectorsize needs to be the maximum of the data and RT
+		 * device.
 		 *
 		 * Some architectures have a page size > XFS_MAX_SECTORSIZE.
 		 * In that case, a ramdisk or persistent memory device may
@@ -2378,8 +2380,18 @@ validate_sectorsize(
 			ft->data.physical_sector_size =
 				ft->data.logical_sector_size;
 		}
-
 		cfg->sectorsize = ft->data.physical_sector_size;
+
+		if (cli->xi->rt.name) {
+			if (ft->rt.physical_sector_size > XFS_MAX_SECTORSIZE) {
+				ft->rt.physical_sector_size =
+					ft->rt.logical_sector_size;
+			}
+
+			if (cfg->sectorsize < ft->rt.physical_sector_size)
+				cfg->sectorsize = ft->rt.physical_sector_size;
+		}
+
 		if (cfg->blocksize < cfg->sectorsize &&
 		    cfg->blocksize >= ft->data.logical_sector_size) {
 			fprintf(stderr,
-- 
2.45.2


             reply	other threads:[~2025-01-27 13:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 13:54 Christoph Hellwig [this message]
2025-01-27 21:37 ` [PATCH] mkfs: use a default sector size that is also suitable for the rtdev Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127135403.525965-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=aalbersh@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox