From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs/614: remove the _require_loop call
Date: Tue, 4 Feb 2025 09:07:14 -0800 [thread overview]
Message-ID: <20250204170714.GC21799@frogsfrogsfrogs> (raw)
In-Reply-To: <20250204134707.2018526-2-hch@lst.de>
On Tue, Feb 04, 2025 at 02:46:55PM +0100, Christoph Hellwig wrote:
> This test only creates file system images as regular files, but never
> actually uses the kernel loop driver. Remove the extra requirement.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Oh, heh, yeah, loopdev not necessary!
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> tests/xfs/614 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/xfs/614 b/tests/xfs/614
> index 06cc2384f38c..f2ea99edb342 100755
> --- a/tests/xfs/614
> +++ b/tests/xfs/614
> @@ -22,7 +22,6 @@ _cleanup()
>
>
> _require_test
> -_require_loop
> $MKFS_XFS_PROG 2>&1 | grep -q concurrency || \
> _notrun "mkfs does not support concurrency options"
>
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2025-02-04 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:46 [PATCH 1/2] xfs/614: query correct direct I/O alignment Christoph Hellwig
2025-02-04 13:46 ` [PATCH 2/2] xfs/614: remove the _require_loop call Christoph Hellwig
2025-02-04 17:07 ` Darrick J. Wong [this message]
2025-02-10 16:21 ` Zorro Lang
2025-02-04 17:12 ` [PATCH 1/2] xfs/614: query correct direct I/O alignment Darrick J. Wong
2025-02-05 15:44 ` Christoph Hellwig
2025-02-05 15:51 ` Darrick J. Wong
2025-02-05 16:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204170714.GC21799@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox