Re: [PATCH v2 1/8] fs/buffer: simplify block_read_full_folio() with bh_offset()

Luis Chamberlain
2025-02-06T17:30:39Z

On Thu, Feb 06, 2025 at 08:17:32AM +0100, Hannes Reinecke wrote:
> On 2/5/25 23:03, Matthew Wilcox wrote:
> > On Wed, Feb 05, 2025 at 05:18:20PM +0100, Hannes Reinecke wrote:
> > > One wonders: shouldn't we use plugging here to make I/O more efficient?
> >
> > Should we plug at a higher level?
> >
> > Opposite question: What if getblk() needs to do a read (ie ext2 indirect
> > block)?
>
> Ah, that. Yes, plugging on higher level would be a good idea.
> (And can we check for nested plugs? _Should_ we check for nested plugs?)

I think given the discussion less is more for now, and if we really want
this we can add it later. Thoughts?

Luis