From: Brian Foster <bfoster@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>
Subject: [PATCH v5 01/10] iomap: factor out iomap length helper
Date: Wed, 5 Feb 2025 08:58:12 -0500 [thread overview]
Message-ID: <20250205135821.178256-2-bfoster@redhat.com> (raw)
In-Reply-To: <20250205135821.178256-1-bfoster@redhat.com>
In preparation to support more granular iomap iter advancing, factor
the pos/len values as parameters to length calculation.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
include/linux/iomap.h | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/include/linux/iomap.h b/include/linux/iomap.h
index 75bf54e76f3b..f5ca71ac2fa2 100644
--- a/include/linux/iomap.h
+++ b/include/linux/iomap.h
@@ -231,18 +231,33 @@ struct iomap_iter {
int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops);
/**
- * iomap_length - length of the current iomap iteration
+ * iomap_length_trim - trimmed length of the current iomap iteration
* @iter: iteration structure
+ * @pos: File position to trim from.
+ * @len: Length of the mapping to trim to.
*
- * Returns the length that the operation applies to for the current iteration.
+ * Returns a trimmed length that the operation applies to for the current
+ * iteration.
*/
-static inline u64 iomap_length(const struct iomap_iter *iter)
+static inline u64 iomap_length_trim(const struct iomap_iter *iter, loff_t pos,
+ u64 len)
{
u64 end = iter->iomap.offset + iter->iomap.length;
if (iter->srcmap.type != IOMAP_HOLE)
end = min(end, iter->srcmap.offset + iter->srcmap.length);
- return min(iter->len, end - iter->pos);
+ return min(len, end - pos);
+}
+
+/**
+ * iomap_length - length of the current iomap iteration
+ * @iter: iteration structure
+ *
+ * Returns the length that the operation applies to for the current iteration.
+ */
+static inline u64 iomap_length(const struct iomap_iter *iter)
+{
+ return iomap_length_trim(iter, iter->pos, iter->len);
}
/**
--
2.48.1
next prev parent reply other threads:[~2025-02-05 13:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 13:58 [PATCH v5 00/10] iomap: incremental per-operation iter advance Brian Foster
2025-02-05 13:58 ` Brian Foster [this message]
2025-02-05 18:49 ` [PATCH v5 01/10] iomap: factor out iomap length helper Darrick J. Wong
2025-02-05 13:58 ` [PATCH v5 02/10] iomap: split out iomap check and reset logic from iter advance Brian Foster
2025-02-05 13:58 ` [PATCH v5 03/10] iomap: refactor iomap_iter() length check and tracepoint Brian Foster
2025-02-05 18:50 ` Darrick J. Wong
2025-02-05 13:58 ` [PATCH v5 04/10] iomap: lift error code check out of iomap_iter_advance() Brian Foster
2025-02-05 18:51 ` Darrick J. Wong
2025-02-05 13:58 ` [PATCH v5 05/10] iomap: lift iter termination logic from iomap_iter_advance() Brian Foster
2025-02-05 19:00 ` Darrick J. Wong
2025-02-05 20:25 ` Brian Foster
2025-02-05 13:58 ` [PATCH v5 06/10] iomap: export iomap_iter_advance() and return remaining length Brian Foster
2025-02-05 18:58 ` Darrick J. Wong
2025-02-05 20:25 ` Brian Foster
2025-02-05 13:58 ` [PATCH v5 07/10] iomap: support incremental iomap_iter advances Brian Foster
2025-02-05 19:10 ` Darrick J. Wong
2025-02-05 20:26 ` Brian Foster
2025-02-05 13:58 ` [PATCH v5 08/10] iomap: advance the iter directly on buffered writes Brian Foster
2025-02-05 19:17 ` Darrick J. Wong
2025-02-05 13:58 ` [PATCH v5 09/10] iomap: advance the iter directly on unshare range Brian Foster
2025-02-05 19:16 ` Darrick J. Wong
2025-02-05 20:27 ` Brian Foster
2025-02-05 20:44 ` Darrick J. Wong
2025-02-05 13:58 ` [PATCH v5 10/10] iomap: advance the iter directly on zero range Brian Foster
2025-02-05 19:15 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205135821.178256-2-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox