From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
zlang@kernel.org, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs/614: query correct direct I/O alignment
Date: Wed, 5 Feb 2025 16:44:22 +0100 [thread overview]
Message-ID: <20250205154422.GC13814@lst.de> (raw)
In-Reply-To: <20250204171258.GD21799@frogsfrogsfrogs>
On Tue, Feb 04, 2025 at 09:12:58AM -0800, Darrick J. Wong wrote:
> Hmmmm... I have a patch with a similar aim in my dev tree that
> determines the lba size from whatever mkfs decides is the sector size:
>
> # Figure out what sector size mkfs will use to format, which might be dependent
> # upon the directio write geometry of the test filesystem.
> loop_file=$TEST_DIR/$seq.loop
> rm -f "$loop_file"
> truncate -s 16M "$loop_file"
> $MKFS_XFS_PROG -f -N "$loop_file" | _filter_mkfs 2>$tmp.mkfs >/dev/null
> . $tmp.mkfs
> seqfull=$0
> _link_out_file "lba${sectsz}"
>
> What do you think of that approach?
That sound sensible. Where is that patch, it doesn't seem to be
in the realtime-reflink branch that I'm usually working against.
next prev parent reply other threads:[~2025-02-05 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:46 [PATCH 1/2] xfs/614: query correct direct I/O alignment Christoph Hellwig
2025-02-04 13:46 ` [PATCH 2/2] xfs/614: remove the _require_loop call Christoph Hellwig
2025-02-04 17:07 ` Darrick J. Wong
2025-02-10 16:21 ` Zorro Lang
2025-02-04 17:12 ` [PATCH 1/2] xfs/614: query correct direct I/O alignment Darrick J. Wong
2025-02-05 15:44 ` Christoph Hellwig [this message]
2025-02-05 15:51 ` Darrick J. Wong
2025-02-05 16:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205154422.GC13814@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox