Re: [PATCH 20/43] xfs: skip zoned RT inodes in xfs_inodegc_want_queue_rt_file

Darrick J. Wong
2025-02-06T21:04:14Z

On Thu, Feb 06, 2025 at 07:44:36AM +0100, Christoph Hellwig wrote:
> The zoned allocator never performs speculative preallocations, so don't
> bother queueing up zoned inodes here.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Makes sense,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> fs/xfs/xfs_icache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index c9ded501e89b..2f53ca7e12d4 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -2073,7 +2073,7 @@ xfs_inodegc_want_queue_rt_file(
> {
> struct xfs_mount *mp = ip->i_mount;
>
> - if (!XFS_IS_REALTIME_INODE(ip))
> + if (!XFS_IS_REALTIME_INODE(ip) || xfs_has_zoned(mp))
> return false;
>
> if (xfs_compare_freecounter(mp, XC_FREE_RTEXTENTS,
> --
> 2.45.2
>
>