Re: [PATCH 35/43] xfs: disable rt quotas for zoned file systems

Darrick J. Wong
2025-02-07T04:31:44Z

On Thu, Feb 06, 2025 at 07:44:51AM +0100, Christoph Hellwig wrote:
> They'll need a little more work.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reluctantly,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> fs/xfs/xfs_qm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index e1ba5af6250f..417439b58785 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -1711,7 +1711,8 @@ xfs_qm_mount_quotas(
> * immediately. We only support rtquota if rtgroups are enabled to
> * avoid problems with older kernels.
> */
> - if (mp->m_sb.sb_rextents && !xfs_has_rtgroups(mp)) {
> + if (mp->m_sb.sb_rextents &&
> + (!xfs_has_rtgroups(mp) || xfs_has_zoned(mp))) {
> xfs_notice(mp, "Cannot turn on quotas for realtime filesystem");
> mp->m_qflags = 0;
> goto write_changes;
> --
> 2.45.2
>
>