public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: da.gomez@kernel.org, linux-xfs@vger.kernel.org,
	Daniel Gomez <da.gomez@samsung.com>,
	Pankaj Raghav <p.raghav@samsung.com>,
	gost.dev@samsung.com
Subject: Re: [PATCH] mkfs: use stx_blksize for dev block size by default
Date: Thu, 6 Feb 2025 15:07:21 -0800	[thread overview]
Message-ID: <20250206230721.GC21808@frogsfrogsfrogs> (raw)
In-Reply-To: <Z6U8tAQ3AKMKIlWs@bombadil.infradead.org>

On Thu, Feb 06, 2025 at 02:50:28PM -0800, Luis Chamberlain wrote:
> On Thu, Feb 06, 2025 at 02:27:16PM -0800, Darrick J. Wong wrote:
> > Now you've decreased the default blocksize to 512 on sda, and md0 gets
> > an impossible 512k blocksize.  Also, disrupting the default 4k blocksize
> > will introduce portability problems with distros that aren't yet
> > shipping 6.12.
> 
> Our default should be 4k, and to address the later we should sanity
> check and user an upper limit of what XFS supports, 64k.

I don't think it's a good idea to boost the default fsblock size beyond
4k until we get further into the era where the major distros are
shipping 6.12 kernels.  I wouldn't want to deal with people accidentally
ending up with an 8k fsblock filesystem that they can't mount on fairly
new things like RHEL9/Debian12/etc.

--D

> Thoughts?
> 
>  Luis
> 

  reply	other threads:[~2025-02-06 23:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 19:00 [PATCH] mkfs: use stx_blksize for dev block size by default da.gomez
2025-02-06 22:27 ` Darrick J. Wong
2025-02-06 22:50   ` Luis Chamberlain
2025-02-06 23:07     ` Darrick J. Wong [this message]
2025-02-07  9:12     ` Daniel Gomez
2025-02-07 19:16       ` Luis Chamberlain
2025-02-07  9:39   ` Daniel Gomez
2025-02-07 19:26   ` Luis Chamberlain
2025-02-07 19:31     ` Darrick J. Wong
2025-02-07 19:44       ` Luis Chamberlain
2025-02-07  4:30 ` Christoph Hellwig
2025-02-07 10:04   ` Daniel Gomez
2025-02-13  4:10     ` Christoph Hellwig
2025-02-13 13:26       ` Daniel Gomez
2025-02-18  8:30         ` Christoph Hellwig
2025-05-09 14:27           ` Luis Chamberlain
2025-05-13  5:33             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206230721.GC21808@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=da.gomez@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=gost.dev@samsung.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox