public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
	Hans Holmberg <hans.holmberg@wdc.com>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 06/43] xfs: generalize the freespace and reserved blocks handling
Date: Fri, 7 Feb 2025 05:21:55 +0100	[thread overview]
Message-ID: <20250207042155.GF5467@lst.de> (raw)
In-Reply-To: <20250206212942.GT21808@frogsfrogsfrogs>

On Thu, Feb 06, 2025 at 01:29:42PM -0800, Darrick J. Wong wrote:
> > Use helpers to access the freespace counters everywhere intead of
> > poking through the abstraction by using the percpu_count helpers
> > directly.  This also switches the flooring of the frextents counter
> > to 0 in statfs for the rthinherit case to a manual min_t call to match
> > the handling of the fdblocks counter for normal file systems.
> 
> It might've been nice to split the m_resblk and the freecounter wrapping
> into two smaller patches, but I can also see that it makes sense to do
> both together.

So you want separate patches for the percpu counters and reservations?
I could look into that, but I'm not sure it really helps understanding
the logic.  But thinking about it we should probably have one array
of structures with the percpu counters and reservations anyway, so
if I redo this anyway I might be able to split it up a little more.


  reply	other threads:[~2025-02-07  4:21 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  6:44 support for zoned devices RFCv2 Christoph Hellwig
2025-02-06  6:44 ` [PATCH 01/43] xfs: factor out a xfs_rt_check_size helper Christoph Hellwig
2025-02-06  6:44 ` [PATCH 02/43] xfs: add a rtg_blocks helper Christoph Hellwig
2025-02-06  6:44 ` [PATCH 03/43] xfs: move xfs_bmapi_reserve_delalloc to xfs_iomap.c Christoph Hellwig
2025-02-06  6:44 ` [PATCH 04/43] xfs: skip always_cow inodes in xfs_reflink_trim_around_shared Christoph Hellwig
2025-02-06 20:13   ` Darrick J. Wong
2025-02-07  4:15     ` Christoph Hellwig
2025-02-07  4:22       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 05/43] xfs: refine the unaligned check for always COW inodes in xfs_file_dio_write Christoph Hellwig
2025-02-06  6:44 ` [PATCH 06/43] xfs: generalize the freespace and reserved blocks handling Christoph Hellwig
2025-02-06 21:29   ` Darrick J. Wong
2025-02-07  4:21     ` Christoph Hellwig [this message]
2025-02-07  4:28       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 07/43] xfs: preserve RT reservations across remounts Christoph Hellwig
2025-02-06 20:14   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 08/43] xfs: reflow xfs_dec_freecounter Christoph Hellwig
2025-02-06 20:14   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 09/43] xfs: trace in-memory freecounters Christoph Hellwig
2025-02-06 20:15   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 10/43] xfs: make metabtree reservations global Christoph Hellwig
2025-02-06 20:50   ` Darrick J. Wong
2025-02-07  4:18     ` Christoph Hellwig
2025-02-07  4:24       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 11/43] xfs: reduce metafile reservations Christoph Hellwig
2025-02-06 20:52   ` Darrick J. Wong
2025-02-07  4:19     ` Christoph Hellwig
2025-02-07  4:26       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 12/43] xfs: support XFS_BMAPI_REMAP in xfs_bmap_del_extent_delay Christoph Hellwig
2025-02-06 20:54   ` Darrick J. Wong
2025-02-07  4:19     ` Christoph Hellwig
2025-02-06  6:44 ` [PATCH 13/43] xfs: add a xfs_rtrmap_highest_rgbno helper Christoph Hellwig
2025-02-06 20:55   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 14/43] xfs: define the zoned on-disk format Christoph Hellwig
2025-02-06 21:00   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 15/43] xfs: allow internal RT devices for zoned mode Christoph Hellwig
2025-02-06  6:44 ` [PATCH 16/43] xfs: export zoned geometry via XFS_FSOP_GEOM Christoph Hellwig
2025-02-06 21:03   ` Darrick J. Wong
2025-02-07  4:20     ` Christoph Hellwig
2025-02-06  6:44 ` [PATCH 17/43] xfs: disable sb_frextents for zoned file systems Christoph Hellwig
2025-02-06  6:44 ` [PATCH 18/43] xfs: disable FITRIM for zoned RT devices Christoph Hellwig
2025-02-06  6:44 ` [PATCH 19/43] xfs: don't call xfs_can_free_eofblocks from ->release for zoned inodes Christoph Hellwig
2025-02-06  6:44 ` [PATCH 20/43] xfs: skip zoned RT inodes in xfs_inodegc_want_queue_rt_file Christoph Hellwig
2025-02-06 21:04   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 21/43] xfs: parse and validate hardware zone information Christoph Hellwig
2025-02-06 21:05   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 22/43] xfs: add the zoned space allocator Christoph Hellwig
2025-02-07 17:39   ` Darrick J. Wong
2025-02-13  5:14     ` Christoph Hellwig
2025-02-13  8:35       ` Christoph Hellwig
2025-02-17  9:20         ` Christoph Hellwig
2025-02-13 22:08       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 23/43] xfs: add support for zoned space reservations Christoph Hellwig
2025-02-07 17:52   ` Darrick J. Wong
2025-02-13  5:17     ` Christoph Hellwig
2025-02-13 22:09       ` Darrick J. Wong
2025-02-14  6:20         ` Christoph Hellwig
2025-02-14 18:25           ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 24/43] xfs: implement zoned garbage collection Christoph Hellwig
2025-02-07 18:33   ` Darrick J. Wong
2025-02-13  5:22     ` Christoph Hellwig
2025-02-13 22:10       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 25/43] xfs: implement buffered writes to zoned RT devices Christoph Hellwig
2025-02-12  0:54   ` Darrick J. Wong
2025-02-13  5:39     ` Christoph Hellwig
2025-02-13 23:05       ` Darrick J. Wong
2025-02-14  6:22         ` Christoph Hellwig
2025-02-14 18:29           ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 26/43] xfs: implement direct " Christoph Hellwig
2025-02-06  6:44 ` [PATCH 27/43] xfs: wire up zoned block freeing in xfs_rtextent_free_finish_item Christoph Hellwig
2025-02-06  6:44 ` [PATCH 28/43] xfs: hide reserved RT blocks from statfs Christoph Hellwig
2025-02-07  4:32   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 29/43] xfs: support growfs on zoned file systems Christoph Hellwig
2025-02-06  6:44 ` [PATCH 30/43] xfs: allow COW forks on zoned file systems in xchk_bmap Christoph Hellwig
2025-02-06  6:44 ` [PATCH 31/43] xfs: support xchk_xref_is_used_rt_space on zoned file systems Christoph Hellwig
2025-02-06  6:44 ` [PATCH 32/43] xfs: support xrep_require_rtext_inuse " Christoph Hellwig
2025-02-06  6:44 ` [PATCH 33/43] xfs: enable fsmap reporting for internal RT devices Christoph Hellwig
2025-02-07  4:39   ` Darrick J. Wong
2025-02-07  4:55     ` Christoph Hellwig
2025-02-06  6:44 ` [PATCH 34/43] xfs: disable reflink for zoned file systems Christoph Hellwig
2025-02-07  4:31   ` Darrick J. Wong
2025-02-07  4:54     ` Christoph Hellwig
2025-02-07  5:05       ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 35/43] xfs: disable rt quotas " Christoph Hellwig
2025-02-07  4:31   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 36/43] xfs: enable the zoned RT device feature Christoph Hellwig
2025-02-06  6:44 ` [PATCH 37/43] xfs: support zone gaps Christoph Hellwig
2025-02-06  6:44 ` [PATCH 38/43] xfs: add a max_open_zones mount option Christoph Hellwig
2025-02-07  4:29   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 39/43] xfs: support write life time based data placement Christoph Hellwig
2025-02-12  0:27   ` Darrick J. Wong
2025-02-12 13:29     ` Hans Holmberg
2025-02-13  4:42       ` Darrick J. Wong
2025-02-13 13:03         ` Hans Holmberg
2025-02-14  6:41           ` hch
2025-02-14 12:20             ` Hans Holmberg
2025-02-14 16:21             ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 40/43] xfs: wire up the show_stats super operation Christoph Hellwig
2025-02-06  6:44 ` [PATCH 41/43] xfs: export zone stats in /proc/*/mountstats Christoph Hellwig
2025-02-07  1:02   ` Darrick J. Wong
2025-02-07  4:25     ` Christoph Hellwig
2025-02-06  6:44 ` [PATCH 42/43] xfs: contain more sysfs code in xfs_sysfs.c Christoph Hellwig
2025-02-07  0:54   ` Darrick J. Wong
2025-02-06  6:44 ` [PATCH 43/43] xfs: export max_open_zones in sysfs Christoph Hellwig
2025-02-07  0:52   ` Darrick J. Wong
2025-02-07  4:23     ` Christoph Hellwig
2025-02-07  4:27       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207042155.GF5467@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hans.holmberg@wdc.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox