Re: [PATCH 19/27] xfs_repair: check existing realtime rmapbt entries against observed rmaps

Christoph Hellwig
2025-02-07T05:35:10Z

On Thu, Feb 06, 2025 at 02:54:41PM -0800, Darrick J. Wong wrote:
> + struct xfs_rmap_irec rmap = {
> + .rm_startblock = 0,
> + .rm_blockcount = mp->m_sb.sb_rextsize,
> + .rm_owner = XFS_RMAP_OWN_FS,
> + .rm_offset = 0,
> + .rm_flags = 0,
> + };

No real need for the zero initializations.

> +
> + if (!rmap_needs_work(mp))
> + return;
> +
> + if (xfs_has_rtsb(mp) && rgno == 0)
> + rmap_add_mem_rec(mp, true, rgno, &rmap);

And it might be a tad cleaner to move the variable into the branch
scope here.

Nitpicks aside, this looks good: