Re: [PATCH v6 00/10] iomap: incremental per-operation iter advance

Brian Foster
2025-02-10T13:51:28Z

On Mon, Feb 10, 2025 at 12:48:14PM +0100, Christian Brauner wrote:
> On Fri, 07 Feb 2025 09:32:43 -0500, Brian Foster wrote:
> > Just a couple comment changes, no code changes from v5.
> >
> > Brian
> >
> > v6:
> > - Comment updates in patches 6 and 7.
> > v5: https://lore.kernel.org/linux-fsdevel/20250205135821.178256-1-bfoster@redhat.com/
> > - Fixed refactoring bug in v4 by pulling 'processed' local var into
> > patch 4.
> > v4: https://lore.kernel.org/linux-fsdevel/20250204133044.80551-1-bfoster@redhat.com/
> > - Reordered patches 1 and 2 to keep iter advance cleanups together.
> > - Split patch 3 from v3 into patches 3-6.
> > v3: https://lore.kernel.org/linux-fsdevel/20250130170949.916098-1-bfoster@redhat.com/
> > - Code style and comment fixups.
> > - Variable type fixups and rework of iomap_iter_advance() to return
> > error/length separately.
> > - Advance the iter on unshare and zero range skip cases instead of
> > returning length.
> > v2: https://lore.kernel.org/linux-fsdevel/20250122133434.535192-1-bfoster@redhat.com/
> > - More refactoring of iomap_iter[_advance]() logic. Lifted out iter
> > continuation and stale logic and improved comments.
> > - Renamed some poorly named helpers and variables.
> > - Return remaining length for current iter from _iter_advance() and use
> > appropriately.
> > v1: https://lore.kernel.org/linux-fsdevel/20241213143610.1002526-1-bfoster@redhat.com/
> > - Reworked and fixed a bunch of functional issues.
> > RFC: https://lore.kernel.org/linux-fsdevel/20241125140623.20633-1-bfoster@redhat.com/
> >
> > [...]
>
> @Brian, you would help me a lot if you keep adding the full cover letter
> message in each series. I always retain the cover letter when I merge
> series such as this. So for work like yours it serves as a design/spec
> document that we can always go back to when we see bugs in that code
> months/years down the line.
>

Ah. Sorry, I wasn't aware of that. I tend to use the cover letter of the
series as a quick update and/or message to reviewers, which ultimately
evolves from the high level technical description in v1 to more brief
notes as the changelog shrinks.

Going forward I'll try to keep the high level technical description from
v1 as its own section and carry that forward in subsequent versions.
Thanks for the feedback.

Brian

> ---
>
> Applied to the vfs-6.15.iomap branch of the vfs/vfs.git tree.
> Patches in the vfs-6.15.iomap branch should appear in linux-next soon.
>
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
>
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-6.15.iomap
>
> [01/10] iomap: factor out iomap length helper
> https://git.kernel.org/vfs/vfs/c/abb0ea1923a6
> [02/10] iomap: split out iomap check and reset logic from iter advance
> https://git.kernel.org/vfs/vfs/c/2e4b0b6cf533
> [03/10] iomap: refactor iomap_iter() length check and tracepoint
> https://git.kernel.org/vfs/vfs/c/f47998386623
> [04/10] iomap: lift error code check out of iomap_iter_advance()
> https://git.kernel.org/vfs/vfs/c/9183b2a0e439
> [05/10] iomap: lift iter termination logic from iomap_iter_advance()
> https://git.kernel.org/vfs/vfs/c/b26f2ea1cd06
> [06/10] iomap: export iomap_iter_advance() and return remaining length
> https://git.kernel.org/vfs/vfs/c/b51d30ff51f9
> [07/10] iomap: support incremental iomap_iter advances
> https://git.kernel.org/vfs/vfs/c/bc264fea0f6f
> [08/10] iomap: advance the iter directly on buffered writes
> https://git.kernel.org/vfs/vfs/c/1a1a3b574b97
> [09/10] iomap: advance the iter directly on unshare range
> https://git.kernel.org/vfs/vfs/c/e60837da4d9d
> [10/10] iomap: advance the iter directly on zero range
> https://git.kernel.org/vfs/vfs/c/cbad829cef3b
>