Re: [PATCH 05/17] xfs_scrub: don't report data loss in unlinked inodes twice

Darrick J. Wong
2025-02-07T04:46:16Z

On Thu, Feb 06, 2025 at 08:35:34PM -0800, Christoph Hellwig wrote:
> On Thu, Feb 06, 2025 at 02:31:57PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > If parent pointers are enabled, report_ioerr_fsmap will report lost file
> > data and xattrs for all files, having used the parent pointer ioctls to
> > generate the path of the lost file. For unlinked files, the path lookup
> > will fail, but we'll report the inumber of the file that lost data.
>
> Maybe also add this to the code as a comment?

Will do.

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D