From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrey Albershteyn <aalbersh@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument
Date: Tue, 18 Feb 2025 21:45:15 -0800 [thread overview]
Message-ID: <20250219054515.GT3028674@frogsfrogsfrogs> (raw)
In-Reply-To: <20250219053717.GD10173@lst.de>
On Wed, Feb 19, 2025 at 06:37:17AM +0100, Christoph Hellwig wrote:
> On Tue, Feb 18, 2025 at 08:08:13PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > libxfs_buf_get_uncached doesn't take a daddr argument, so don't pass one
> > as the flags argument. Also take the opportunity to use
> > xfs_buf_set_daddr to set the actual disk address.
>
> Should it take a daddr argument? I've been wondering that a bit as the
> interface that doesn't pass one seems a bit odd.
We'd have to change the kernel first, there are libxfs callers with that
signature.
> The patch itself looks fine, although I don't really see the point in
> the xfsprogs-only xfs_buf_set_daddr (including the current two callers).
Eh, yeah. Want me to resend with those bits cut out?
--D
next prev parent reply other threads:[~2025-02-19 5:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 4:08 [PATCH 1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument Darrick J. Wong
2025-02-19 4:08 ` [PATCH 2/2] xfs_db: obfuscate rt superblock label when metadumping Darrick J. Wong
2025-02-19 5:37 ` Christoph Hellwig
2025-02-19 5:37 ` [PATCH 1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument Christoph Hellwig
2025-02-19 5:45 ` Darrick J. Wong [this message]
2025-02-19 5:48 ` Christoph Hellwig
2025-02-19 5:53 ` Darrick J. Wong
2025-02-19 5:46 ` [PATCH v1.1 " Darrick J. Wong
2025-02-19 5:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219054515.GT3028674@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox