From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrey Albershteyn <aalbersh@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument
Date: Wed, 19 Feb 2025 06:48:51 +0100 [thread overview]
Message-ID: <20250219054851.GA10520@lst.de> (raw)
In-Reply-To: <20250219054515.GT3028674@frogsfrogsfrogs>
On Tue, Feb 18, 2025 at 09:45:15PM -0800, Darrick J. Wong wrote:
> > The patch itself looks fine, although I don't really see the point in
> > the xfsprogs-only xfs_buf_set_daddr (including the current two callers).
>
> Eh, yeah. Want me to resend with those bits cut out?
As long as the helper is around there's probably no reason not to use
it. Removing it would probably pair pretty well with passing a daddr
to xfs_get_buf_uncached. Or maybe killing xfs_{get,read}_buf_uncached
entirely in favor of just using xfs_buf_oneshot more..
next prev parent reply other threads:[~2025-02-19 5:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 4:08 [PATCH 1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument Darrick J. Wong
2025-02-19 4:08 ` [PATCH 2/2] xfs_db: obfuscate rt superblock label when metadumping Darrick J. Wong
2025-02-19 5:37 ` Christoph Hellwig
2025-02-19 5:37 ` [PATCH 1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument Christoph Hellwig
2025-02-19 5:45 ` Darrick J. Wong
2025-02-19 5:48 ` Christoph Hellwig [this message]
2025-02-19 5:53 ` Darrick J. Wong
2025-02-19 5:46 ` [PATCH v1.1 " Darrick J. Wong
2025-02-19 5:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219054851.GA10520@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox