* [PATCH] mkfs: Correct filesize declaration
@ 2025-02-23 14:16 ` Bastian Germann
2025-02-24 9:31 ` Carlos Maiolino
0 siblings, 1 reply; 2+ messages in thread
From: Bastian Germann @ 2025-02-23 14:16 UTC (permalink / raw)
To: linux-xfs; +Cc: Bastian Germann
The filesize() implementation was changed to return off_t.
Its declaration still has long. Fix the declaration.
Fixes: 73fb78e5ee8940 ("mkfs: support copying in large or sparse files")
Signed-off-by: Bastian Germann <bage@debian.org>
---
mkfs/proto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/proto.c b/mkfs/proto.c
index 6dd3a200..981f5b11 100644
--- a/mkfs/proto.c
+++ b/mkfs/proto.c
@@ -20,7 +20,7 @@ static struct xfs_trans * getres(struct xfs_mount *mp, uint blocks);
static void rsvfile(xfs_mount_t *mp, xfs_inode_t *ip, long long len);
static int newregfile(char **pp, char **fname);
static void rtinit(xfs_mount_t *mp);
-static long filesize(int fd);
+static off_t filesize(int fd);
static int slashes_are_spaces;
/*
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mkfs: Correct filesize declaration
2025-02-23 14:16 ` [PATCH] mkfs: Correct filesize declaration Bastian Germann
@ 2025-02-24 9:31 ` Carlos Maiolino
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2025-02-24 9:31 UTC (permalink / raw)
To: Bastian Germann; +Cc: linux-xfs
On Sun, Feb 23, 2025 at 03:16:54PM +0100, Bastian Germann wrote:
> The filesize() implementation was changed to return off_t.
> Its declaration still has long. Fix the declaration.
>
> Fixes: 73fb78e5ee8940 ("mkfs: support copying in large or sparse files")
> Signed-off-by: Bastian Germann <bage@debian.org>
https://lore.kernel.org/linux-xfs/20250217155043.78452-1-preichl@redhat.com/T/#m90c87f94c6f85445432f403c57e8eeb8cf0c92c6
> ---
> mkfs/proto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/proto.c b/mkfs/proto.c
> index 6dd3a200..981f5b11 100644
> --- a/mkfs/proto.c
> +++ b/mkfs/proto.c
> @@ -20,7 +20,7 @@ static struct xfs_trans * getres(struct xfs_mount *mp, uint blocks);
> static void rsvfile(xfs_mount_t *mp, xfs_inode_t *ip, long long len);
> static int newregfile(char **pp, char **fname);
> static void rtinit(xfs_mount_t *mp);
> -static long filesize(int fd);
> +static off_t filesize(int fd);
> static int slashes_are_spaces;
>
> /*
> --
> 2.48.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-24 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AC2xTDvxLrb9fDp2I7P3JDsI4ZBtGzO3sE-QruF5E6XnVkYJTWianMNi0rLM0B5_2Y5vXfzx1ayh1klhTNOu5A==@protonmail.internalid>
2025-02-23 14:16 ` [PATCH] mkfs: Correct filesize declaration Bastian Germann
2025-02-24 9:31 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox