From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 375D03DBB6; Mon, 24 Feb 2025 16:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740412939; cv=none; b=bq051w5ItwzzWI24+YJWsYEYSh6hYxYZOCvHrnkoxlZDT4MD8iqMJUWVZu8taqxaFdaY7dGDA/zfiASgWF0WebBfJo0yNkW18suQQqRqDN8aKR3yzfsOrzoqZVKXZnXfLem94k5+4Bw8mJqyPhzhog/p+zzL2aenjn/5Nku9RmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740412939; c=relaxed/simple; bh=KGTWjvtb+6Tnwgqf+kMV6m/4VPxG7L1QgxU5BeApu80=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PiYUdDUL4qX4s+WAxjLtagKMSMQs+FVjdoDdA6aNreyv5aKfehKz9K2vFZDsCxEy++8sZtJ0r376o3iMdZkWpryvgk9XxqS6BjjZRANdASFZF35Cvd41EyrHGX+yWZXtvsOCjcKL71bOIbAll91GzAueLfzIRyRsnWOhdVtR4kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 7B47268BFE; Mon, 24 Feb 2025 17:02:10 +0100 (CET) Date: Mon, 24 Feb 2025 17:02:09 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Raphael S. Carvalho" , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, Dave Chinner Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT Message-ID: <20250224160209.GA4701@lst.de> References: <20250224081328.18090-1-raphaelsc@scylladb.com> <20250224141744.GA1088@lst.de> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Feb 24, 2025 at 03:33:29PM +0000, Matthew Wilcox wrote: > I don't think it needs a comment at all, but the memory allocation > might be for something other than folios, so your suggested comment > is misleading. Then s/folio/memory/