From: "Darrick J. Wong" <djwong@kernel.org>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, zlang@kernel.org, david@fromorbit.com
Subject: Re: [PATCH v1 1/2] generic/749: Remove redundant sourcing of common/rc
Date: Thu, 6 Mar 2025 09:41:57 -0800 [thread overview]
Message-ID: <20250306174157.GO2803749@frogsfrogsfrogs> (raw)
In-Reply-To: <149c6c0678803e07e7f31f23df4b3036f7daf17f.1741248214.git.nirjhar.roy.lists@gmail.com>
On Thu, Mar 06, 2025 at 08:17:40AM +0000, Nirjhar Roy (IBM) wrote:
> common/rc is already sourced before the test starts running
> in _begin_fstest() preamble.
>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Yeah, that sourceing shouldn't be necessary.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> tests/generic/749 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/749 b/tests/generic/749
> index fc747738..451f283e 100755
> --- a/tests/generic/749
> +++ b/tests/generic/749
> @@ -15,7 +15,6 @@
> # boundary and ensures we get a SIGBUS if we write to data beyond the system
> # page size even if the block size is greater than the system page size.
> . ./common/preamble
> -. ./common/rc
> _begin_fstest auto quick prealloc
>
> # Import common functions.
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2025-03-06 17:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 8:17 [PATCH v1 0/2] Minor cleanups in common/rc Nirjhar Roy (IBM)
2025-03-06 8:17 ` [PATCH v1 1/2] generic/749: Remove redundant sourcing of common/rc Nirjhar Roy (IBM)
2025-03-06 17:41 ` Darrick J. Wong [this message]
2025-03-06 8:17 ` [PATCH v1 2/2] check,common/{preamble,rc},soak: Decoupling init_rc() call from sourcing common/rc Nirjhar Roy (IBM)
2025-03-06 17:46 ` Darrick J. Wong
2025-03-07 5:51 ` Nirjhar Roy (IBM)
2025-03-07 17:40 ` Darrick J. Wong
2025-03-12 5:46 ` Nirjhar Roy (IBM)
2025-03-18 4:57 ` Nirjhar Roy (IBM)
2025-03-06 21:13 ` Zorro Lang
2025-03-07 5:56 ` Nirjhar Roy (IBM)
2025-03-06 21:30 ` Dave Chinner
2025-03-07 8:05 ` Nirjhar Roy (IBM)
2025-03-08 7:20 ` Zorro Lang
2025-03-10 8:06 ` Zorro Lang
2025-03-12 4:41 ` Nirjhar Roy (IBM)
2025-03-12 4:41 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306174157.GO2803749@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox