Re: [PATCH 08/17] xfs: check for zoned-specific errors in _try_scratch_mkfs_xfs

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Mar 12, 2025 at 07:45:00AM +0100, Christoph Hellwig wrote:
> Check for a few errors issued for unsupported zoned configurations in
> _try_scratch_mkfs_xfs so that the test is not run instead of failed.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  common/xfs | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/common/xfs b/common/xfs
> index 93260fdb4599..807454d3e03b 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -160,6 +160,11 @@ _try_scratch_mkfs_xfs()
>  
>  	grep -q crc=0 $tmp.mkfsstd && _force_xfsv4_mount_options
>  
> +	grep -q "zoned file systems do not support" $tmp.mkfserr && \
> +		_notrun "Not supported on zoned file systems"
> +	grep -q "must be greater than the minimum" $tmp.mkfserr && \

Hmmm... this doesn't mention the word "zone" at all.

Maybe that error message in calculate_zone_geometry should read:

"realtime group count (%llu) must be greater than the minimum (%u) zone count" ?

and I think you should post the xfsprogs zoned patches.

--D

> +		_notrun "Zone count too small"
> +
>  	if [ $mkfs_status -eq 0 -a "$LARGE_SCRATCH_DEV" = yes ]; then
>  		# manually parse the mkfs output to get the fs size in bytes
>  		local fs_size
> -- 
> 2.45.2
> 
>