public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
	Hans Holmberg <hans.holmberg@wdc.com>,
	fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 08/17] xfs: check for zoned-specific errors in _try_scratch_mkfs_xfs
Date: Thu, 13 Mar 2025 08:26:37 +0100	[thread overview]
Message-ID: <20250313072637.GD11310@lst.de> (raw)
In-Reply-To: <20250312201725.GH2803749@frogsfrogsfrogs>

On Wed, Mar 12, 2025 at 01:17:25PM -0700, Darrick J. Wong wrote:
> > +	grep -q "zoned file systems do not support" $tmp.mkfserr && \
> > +		_notrun "Not supported on zoned file systems"
> > +	grep -q "must be greater than the minimum" $tmp.mkfserr && \
> 
> Hmmm... this doesn't mention the word "zone" at all.
> 
> Maybe that error message in calculate_zone_geometry should read:
> 
> "realtime group count (%llu) must be greater than the minimum (%u) zone count" ?

Yeah.

> and I think you should post the xfsprogs zoned patches.

Still waiting for a baseline to post against, i.e. rtrmap and rtreflink
being merged.


  reply	other threads:[~2025-03-13  7:26 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  6:44 initial xfstests support for zoned XFS Christoph Hellwig
2025-03-12  6:44 ` [PATCH 01/17] xfs/177: force a small file system size Christoph Hellwig
2025-03-12 19:56   ` Darrick J. Wong
2025-03-12  6:44 ` [PATCH 02/17] xfs/419: use _scratch_mkfs_xfs Christoph Hellwig
2025-03-12 20:05   ` Darrick J. Wong
2025-03-13  7:24     ` Christoph Hellwig
2025-03-12  6:44 ` [PATCH 03/17] xfs/540: " Christoph Hellwig
2025-03-12 20:07   ` Darrick J. Wong
2025-03-12  6:44 ` [PATCH 04/17] common: extend the zoned device checks in _require_dm_target Christoph Hellwig
2025-03-12 20:09   ` Darrick J. Wong
2025-03-12  6:44 ` [PATCH 05/17] common: allow _require_non_zoned_device without an argument Christoph Hellwig
2025-03-12 20:10   ` Darrick J. Wong
2025-03-13  7:24     ` Christoph Hellwig
2025-03-12  6:44 ` [PATCH 06/17] common: support internal RT device in _require_realtime Christoph Hellwig
2025-03-12 20:12   ` Darrick J. Wong
2025-03-13  7:25     ` Christoph Hellwig
2025-03-12  6:44 ` [PATCH 07/17] common: support internal RT devices in scratch_mkfs_sized Christoph Hellwig
2025-03-12 20:15   ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 08/17] xfs: check for zoned-specific errors in _try_scratch_mkfs_xfs Christoph Hellwig
2025-03-12 20:17   ` Darrick J. Wong
2025-03-13  7:26     ` Christoph Hellwig [this message]
2025-03-13 17:14       ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 09/17] common: notrun in mkfs_dev for too small zoned file systems Christoph Hellwig
2025-03-12 20:18   ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 10/17] xfs: add helpers to require zoned/non-zoned " Christoph Hellwig
2025-03-12 20:19   ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 11/17] xfs: handle zoned file systems in _scratch_xfs_force_no_metadir Christoph Hellwig
2025-03-12 20:23   ` Darrick J. Wong
2025-03-13  7:28     ` Christoph Hellwig
2025-03-13 17:18       ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 12/17] xfs: no quota support with internal rtdev Christoph Hellwig
2025-03-12 20:25   ` Darrick J. Wong
2025-03-13  7:30     ` Christoph Hellwig
2025-03-12  6:45 ` [PATCH 13/17] xfs: xfs_copy doesn't like RT sections Christoph Hellwig
2025-03-12 20:25   ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 14/17] xfs: skip filestreams tests on internal RT devices Christoph Hellwig
2025-03-12 20:26   ` Darrick J. Wong
2025-03-13  7:31     ` Christoph Hellwig
2025-03-12  6:45 ` [PATCH 15/17] xfs: skip various tests on zoned devices Christoph Hellwig
2025-03-12 20:27   ` Darrick J. Wong
2025-03-13  7:32     ` Christoph Hellwig
2025-03-13 17:19       ` Darrick J. Wong
2025-03-12  6:45 ` [PATCH 16/17] xfs: skip various tests when using the zoned allocator Christoph Hellwig
2025-03-12 20:30   ` Darrick J. Wong
2025-03-13  7:33     ` Christoph Hellwig
2025-03-12  6:45 ` [PATCH 17/17] xfs/206: filter out the zoned line from mkfs output Christoph Hellwig
2025-03-12 20:20   ` Darrick J. Wong
2025-03-12 20:30 ` initial xfstests support for zoned XFS Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313072637.GD11310@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hans.holmberg@wdc.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox