Re: [PATCH v6 03/13] iomap: rework IOMAP atomic flags

Christoph Hellwig
2025-03-18T05:32:19Z

On Mon, Mar 17, 2025 at 09:05:39AM +0000, John Garry wrote:
>> Same here (at least for now until it is changed later).
>
> Please note that Christian plans on sending the earlier iomap changes
> related to this work for 6.15. Those changes are also in the xfs queue. We
> are kinda reverting those changes here, so I think that it would still make
> sense for the iomap changes in this series to make 6.15
>
> The xfs changes in this series are unlikely to make 6.15
>
> As such, if we say that ext4 always uses hardware atomics, then we should
> mention that xfs does also (until it doesn't).

That's what I meant.

> So, in the end, I'd rather not add those comments at all - ok?

If I read through this code it would be kinda nice to figure out why
we're instructing the iomap code to do it. If you look at
xfs_direct_write_iomap_begin it also generally comments on why we
set specific flags.