public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [bug report] xfs: use vmalloc instead of vm_map_area for buffer backing memory
Date: Wed, 19 Mar 2025 07:31:13 +0100	[thread overview]
Message-ID: <20250319063113.GA23743@lst.de> (raw)
In-Reply-To: <91be50b2-1c02-4952-8603-6803dd64f42d@stanley.mountain>

On Tue, Mar 18, 2025 at 11:40:47AM +0300, Dan Carpenter wrote:
> Hello Christoph Hellwig,
> 
> Commit e2874632a621 ("xfs: use vmalloc instead of vm_map_area for
> buffer backing memory") from Mar 10, 2025 (linux-next), leads to the
> following Smatch static checker warning:

Just a question to reconfirm how smatch works:  the vm_unmap_ram
replaced by vfree in this patch also had a might_sleep(), so I think
this bug is older and the check should have also triggeted before.
Or am I missing something?


  parent reply	other threads:[~2025-03-19  6:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  8:40 [bug report] xfs: use vmalloc instead of vm_map_area for buffer backing memory Dan Carpenter
2025-03-18  8:43 ` Christoph Hellwig
2025-03-19  6:31 ` Christoph Hellwig [this message]
2025-03-19  7:16   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250319063113.GA23743@lst.de \
    --to=hch@lst.de \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox