From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 05/13] common: allow _require_non_zoned_device without an argument
Date: Fri, 21 Mar 2025 08:17:08 -0700 [thread overview]
Message-ID: <20250321151708.GF2803749@frogsfrogsfrogs> (raw)
In-Reply-To: <20250321072145.1675257-6-hch@lst.de>
On Fri, Mar 21, 2025 at 08:21:34AM +0100, Christoph Hellwig wrote:
> So that callers can pass $SCRATCH_RTDEV directly without needing to check
> that it actually is set.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> common/rc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 7cd8d5ffd2e8..dc6d4ce01e05 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2545,8 +2545,7 @@ _require_non_zoned_device()
> {
> local target=$1
> if [ -z $target ]; then
> - echo "Usage: _require_non_zoned_device <device>"
> - exit 1
> + return
> fi
>
> local type=`_zone_type ${target}`
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2025-03-21 15:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 7:21 initial xfstests support for zoned XFS v2 Christoph Hellwig
2025-03-21 7:21 ` [PATCH 01/13] xfs/177: force a small file system size Christoph Hellwig
2025-03-21 7:21 ` [PATCH 02/13] xfs/419: use _scratch_mkfs_xfs Christoph Hellwig
2025-03-21 7:21 ` [PATCH 03/13] xfs/540: " Christoph Hellwig
2025-03-21 7:21 ` [PATCH 04/13] common: extend the zoned device checks in _require_dm_target Christoph Hellwig
2025-03-21 7:21 ` [PATCH 05/13] common: allow _require_non_zoned_device without an argument Christoph Hellwig
2025-03-21 15:17 ` Darrick J. Wong [this message]
2025-03-21 7:21 ` [PATCH 06/13] xfs: add helpers to require zoned/non-zoned file systems Christoph Hellwig
2025-03-21 7:21 ` [PATCH 07/13] xfs: handle zoned file systems in _scratch_xfs_force_no_metadir Christoph Hellwig
2025-03-21 15:18 ` Darrick J. Wong
2025-03-21 7:21 ` [PATCH 08/13] xfs: no quota support with internal rtdev Christoph Hellwig
2025-03-21 7:21 ` [PATCH 09/13] xfs: xfs_copy doesn't like RT sections Christoph Hellwig
2025-03-21 15:20 ` Darrick J. Wong
2025-03-21 7:21 ` [PATCH 10/13] xfs: skip filestreams tests on internal RT devices Christoph Hellwig
2025-03-21 7:21 ` [PATCH 11/13] xfs: skip various tests when using the zoned allocator Christoph Hellwig
2025-03-21 15:21 ` Darrick J. Wong
2025-03-21 7:21 ` [PATCH 12/13] xfs/049: skip on zoned devices Christoph Hellwig
2025-03-21 15:21 ` Darrick J. Wong
2025-03-21 7:21 ` [PATCH 13/13] xfs/206: filter out the zoned line from mkfs output Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321151708.GF2803749@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox