Re: [PATCH, resend] xfs: remove the post-EOF prealloc tests from the auto and quick groups

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Apr 08, 2025 at 08:51:55AM +0200, Christoph Hellwig wrote:
> These fail for various non-default configs like DAX, alwayscow and
> small block sizes.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> 
> Resend.  Last time Darrick said he's working on an autodetection, but that
> didn't get finished.

In the end it was much too tricky to autodetect because there are
various paths that never invoke prealloc at all, or on some configs
(e.g.  tiny fs) it can disappear by the time the critical checks in the
test run and *poof*.  For now this is probably fine, though for anyone
else running ./check -g all, the field is open for anyone to try to sort
things out.

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> 
>  tests/xfs/629 | 2 +-
>  tests/xfs/630 | 2 +-
>  tests/xfs/631 | 2 +-
>  tests/xfs/632 | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/xfs/629 b/tests/xfs/629
> index a2f345571ca3..bb59e421e43a 100755
> --- a/tests/xfs/629
> +++ b/tests/xfs/629
> @@ -8,7 +8,7 @@
>  #
>  
>  . ./common/preamble
> -_begin_fstest auto quick prealloc rw
> +_begin_fstest prealloc rw
>  
>  . ./common/filter
>  
> diff --git a/tests/xfs/630 b/tests/xfs/630
> index 79dcb44bc066..0a3fce10c68f 100755
> --- a/tests/xfs/630
> +++ b/tests/xfs/630
> @@ -8,7 +8,7 @@
>  #
>  
>  . ./common/preamble
> -_begin_fstest auto quick prealloc rw
> +_begin_fstest prealloc rw
>  
>  . ./common/filter
>  
> diff --git a/tests/xfs/631 b/tests/xfs/631
> index 319995f816fe..ece491722557 100755
> --- a/tests/xfs/631
> +++ b/tests/xfs/631
> @@ -13,7 +13,7 @@
>  # from the extent size hint.
>  
>  . ./common/preamble
> -_begin_fstest auto quick prealloc rw unreliable_in_parallel
> +_begin_fstest prealloc rw unreliable_in_parallel
>  
>  . ./common/filter
>  
> diff --git a/tests/xfs/632 b/tests/xfs/632
> index 61041d45a706..3b1c61fdc129 100755
> --- a/tests/xfs/632
> +++ b/tests/xfs/632
> @@ -9,7 +9,7 @@
>  #
>  
>  . ./common/preamble
> -_begin_fstest auto prealloc rw
> +_begin_fstest prealloc rw
>  
>  . ./common/filter
>  
> -- 
> 2.47.2
> 
>