Re: [PATCH 13/45] FIXUP: xfs: allow internal RT devices for zoned mode

[Christoph Hellwig <hch@lst.de>]

On Wed, Apr 09, 2025 at 08:55:48AM -0700, Darrick J. Wong wrote:
> Hum.  This change means that if you call xfs_db -c info without
> supplying a realtime device, the info command output will claim an
> internal rt device:
> 
> $ truncate -s 3g /tmp/a
> $ truncate -s 3g /tmp/b
> $ mkfs.xfs -f /tmp/a -r rtdev=/tmp/b
> $ xfs_db -c info /tmp/a

I guess this wants a regression test while we're at it.

> static inline const char *
> rtdev_name(
> 	const struct xfs_fsop_geo	*geo,
> 	const char			*rtname)
> {
> 	if (!geo->rtblocks)
> 		return _("none");
> 	if (geo->rtstart)
> 		return _("internal");
> 	if (!rtname)
> 		return _("external");
> 	return rtname;
> }
> 
> instead?

That should work.  Although the rtstart handling needs to be later
as it doesn't exist yet here.  I've added the helper for now and
will see how it works out while I finish the rebase.