From: Luca Di Maio <luca.dimaio1@gmail.com>
To: linux-xfs@vger.kernel.org
Cc: Luca Di Maio <luca.dimaio1@gmail.com>,
dimitri.ledkov@chainguard.dev, smoser@chainguard.dev
Subject: [PATCH] xfs_profile: fix permission octet when suid/guid is set
Date: Wed, 16 Apr 2025 14:35:00 +0200 [thread overview]
Message-ID: <20250416123508.900340-1-luca.dimaio1@gmail.com> (raw)
When encountering suid or sgid files, we already set the `u` or `g` property
in the prototype file.
Given that proto.c only supports three numbers for permissions, we need to
remove the redundant information from the permission, else it was incorrectly
parsed.
Before:
wall --g2755 0 0 rootfs/usr/bin/wall
sudo -u-4755 0 0 rootfs/usr/bin/sudo
This wrongly generates (suid + 475 permissions):
-r-Srwxr-x. 1 root root 514704 Apr 16 11:56 /usr/bin/su
After:
wall --g755 0 0 rootfs/usr/bin/wall
sudo -u-755 0 0 rootfs/usr/bin/sudo
This correctly generates (suid + 755 permissions):
-rwsr-xr-x 1 root root 514704 Apr 16 11:56 /usr/bin/su
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
---
mkfs/xfs_protofile.in | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mkfs/xfs_protofile.in b/mkfs/xfs_protofile.in
index e83c39f..9672ca3 100644
--- a/mkfs/xfs_protofile.in
+++ b/mkfs/xfs_protofile.in
@@ -43,7 +43,13 @@ def stat_to_str(statbuf):
else:
sgid = '-'
+ # We already register suid in the proto string, no need
+ # to also represent it into the octet
perms = stat.S_IMODE(statbuf.st_mode)
+ if suid == 'u':
+ perms = perms & ~stat.S_ISUID
+ if sgid == 'g':
+ perms = perms & ~stat.S_ISGID
return '%s%s%s%03o %d %d' % (type, suid, sgid, perms, statbuf.st_uid, \
statbuf.st_gid)
2.49.0
next reply other threads:[~2025-04-16 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 12:35 Luca Di Maio [this message]
2025-04-16 15:40 ` [PATCH] xfs_profile: fix permission octet when suid/guid is set Darrick J. Wong
2025-04-16 16:16 ` Luca Di Maio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416123508.900340-1-luca.dimaio1@gmail.com \
--to=luca.dimaio1@gmail.com \
--cc=dimitri.ledkov@chainguard.dev \
--cc=linux-xfs@vger.kernel.org \
--cc=smoser@chainguard.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox