Re: [PATCH 2/2] xfs: add mount test for read only log devices

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Apr 28, 2025 at 12:16:34PM +0000, Hans Holmberg wrote:
> On 25/04/2025 17:05, Darrick J. Wong wrote:
> > ps this test should check
> > that a readonly log device results in a norecovery mount and that
> > pending changes don't show up if the mount succeeds?
> > 
> > Also, ext4 supports external log devices, should this be in
> > tests/generic?
> 
> Doh!, actually ext4 has a test for this already, ext4/002
> (also based on generic/050)
> 
> With my fix, ext4/002 passes for xfs Should/can we turn that into a
> generic test?

Yeah, it looks like ext4/002 already does most of what you want.  Though
I'd amend it to check that SCRATCH_MNT/00-99 aren't visible in the
norecovery mounts and only appear after recovery actually runs.

> The test makes sure that a filesystem will mount ro,norecovery if
> the log device is ro but does not do any real checks if recovery is
> prevented (or done once the log device is rw again).
> That could be added though.

<nod>

--D