Re: [PATCH] xfs: remove the EXPERIMENTAL warning for pNFS

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, May 13, 2025 at 07:30:33AM +0200, Christoph Hellwig wrote:
> The pNFS layout support has been around for 10 years without major
> issues, drop the EXPERIMENTAL warning.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> 
> This is ontop of "xfs: remove some EXPERIMENTAL warnings" from Darrick.
> 
>  fs/xfs/xfs_message.c | 4 ----
>  fs/xfs/xfs_message.h | 1 -
>  fs/xfs/xfs_pnfs.c    | 2 --
>  3 files changed, 7 deletions(-)
> 
> diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
> index 54fc5ada519c..19aba2c3d525 100644
> --- a/fs/xfs/xfs_message.c
> +++ b/fs/xfs/xfs_message.c
> @@ -141,10 +141,6 @@ xfs_warn_experimental(
>  		const char		*name;
>  		long			opstate;
>  	} features[] = {
> -		[XFS_EXPERIMENTAL_PNFS] = {
> -			.opstate	= XFS_OPSTATE_WARNED_PNFS,

Looks fine, but you ought to remove XFS_OPSTATE_WARNED_PNFS from
xfs_mount.h as I forgot to do in my patch. :(

--D

> -			.name		= "pNFS",
> -		},
>  		[XFS_EXPERIMENTAL_SHRINK] = {
>  			.opstate	= XFS_OPSTATE_WARNED_SHRINK,
>  			.name		= "online shrink",
> diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
> index bce9942f394a..d68e72379f9d 100644
> --- a/fs/xfs/xfs_message.h
> +++ b/fs/xfs/xfs_message.h
> @@ -91,7 +91,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
>  			       const char *fmt, ...);
>  
>  enum xfs_experimental_feat {
> -	XFS_EXPERIMENTAL_PNFS,
>  	XFS_EXPERIMENTAL_SHRINK,
>  	XFS_EXPERIMENTAL_LARP,
>  	XFS_EXPERIMENTAL_LBS,
> diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
> index 6f4479deac6d..afe7497012d4 100644
> --- a/fs/xfs/xfs_pnfs.c
> +++ b/fs/xfs/xfs_pnfs.c
> @@ -58,8 +58,6 @@ xfs_fs_get_uuid(
>  {
>  	struct xfs_mount	*mp = XFS_M(sb);
>  
> -	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PNFS);
> -
>  	if (*len < sizeof(uuid_t))
>  		return -EINVAL;
>  
> -- 
> 2.47.2
> 
>