From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Carlos Maiolino <cem@kernel.org>, Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: [PATCH v2 09/13] xfs: remove unused event xfs_alloc_near_nominleft
Date: Mon, 16 Jun 2025 13:51:55 -0400 [thread overview]
Message-ID: <20250616175258.024016837@goodmis.org> (raw)
In-Reply-To: 20250616175146.813055227@goodmis.org
From: Steven Rostedt <rostedt@goodmis.org>
When the function xfs_alloc_space_available() was restructured, it removed
the only calls to the trace event xfs_alloc_near_nominleft. As trace
events take up to 5K of memory for text and meta data for each event, they
should not be created when not used. Remove this unused event.
Fixes: 54fee133ad59 ("xfs: adjust allocation length in xfs_alloc_space_available")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
fs/xfs/xfs_trace.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index d4004e21d0c5..e629ee44a9a1 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -2263,7 +2263,6 @@ DEFINE_EVENT(xfs_alloc_class, name, \
DEFINE_ALLOC_EVENT(xfs_alloc_exact_done);
DEFINE_ALLOC_EVENT(xfs_alloc_exact_notfound);
DEFINE_ALLOC_EVENT(xfs_alloc_exact_error);
-DEFINE_ALLOC_EVENT(xfs_alloc_near_nominleft);
DEFINE_ALLOC_EVENT(xfs_alloc_near_first);
DEFINE_ALLOC_EVENT(xfs_alloc_cur);
DEFINE_ALLOC_EVENT(xfs_alloc_cur_right);
--
2.47.2
next prev parent reply other threads:[~2025-06-16 17:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 17:51 [PATCH v2 00/13] xfs: tracing: remove unused event xfs_reflink_cow_found Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 01/13] xfs: remove unused trace event xfs_attr_remove_iter_return Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 02/13] xfs: remove unused event xlog_iclog_want_sync Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 03/13] xfs: remove unused event xfs_ioctl_clone Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 04/13] xfs: remove unused xfs_reflink_compare_extents events Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 05/13] xfs: remove unused trace event xfs_attr_rmtval_set Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 06/13] xfs: remove unused xfs_attr events Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 07/13] xfs: remove unused event xfs_attr_node_removename Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 08/13] xfs: remove unused event xfs_alloc_near_error Steven Rostedt
2025-06-16 17:51 ` Steven Rostedt [this message]
2025-06-16 17:51 ` [PATCH v2 10/13] xfs: remove unused event xfs_pagecache_inval Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 11/13] xfs: remove usused xfs_end_io_direct events Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 12/13] xfs: only create event xfs_file_compat_ioctl when CONFIG_COMPAT is configure Steven Rostedt
2025-06-16 17:51 ` [PATCH v2 13/13] xfs: change xfs_xattr_class from a TRACE_EVENT() to DECLARE_EVENT_CLASS() Steven Rostedt
2025-06-16 19:18 ` [PATCH v2 00/13] xfs: tracing: remove unused event xfs_reflink_cow_found Steven Rostedt
2025-07-08 22:09 ` Steven Rostedt
2025-07-09 7:52 ` Carlos Maiolino
2025-07-09 7:54 ` Carlos Maiolino
2025-07-09 14:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616175258.024016837@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).