From: Pranav Tyagi <pranav.tyagi03@gmail.com>
To: Carlos Maiolino <cem@kernel.org>
Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Pranav Tyagi <pranav.tyagi03@gmail.com>
Subject: [PATCH] fs/xfs: replace strncpy with strscpy
Date: Tue, 17 Jun 2025 18:15:46 +0530 [thread overview]
Message-ID: <20250617124546.24102-1-pranav.tyagi03@gmail.com> (raw)
Replace the deprecated strncpy() with strscpy() as the destination
buffer should be NUL-terminated and does not require any trailing
NUL-padding. Also, since NUL-termination is guaranteed,
use sizeof(label) in place of XFSLABEL_MAX as the size
parameter.
Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
fs/xfs/xfs_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index d250f7f74e3b..9f4d68c5b5ab 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -992,7 +992,7 @@ xfs_ioc_getlabel(
/* 1 larger than sb_fname, so this ensures a trailing NUL char */
memset(label, 0, sizeof(label));
spin_lock(&mp->m_sb_lock);
- strncpy(label, sbp->sb_fname, XFSLABEL_MAX);
+ strscpy(label, sbp->sb_fname, sizeof(label));
spin_unlock(&mp->m_sb_lock);
if (copy_to_user(user_label, label, sizeof(label)))
--
2.49.0
next reply other threads:[~2025-06-17 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BgUaxdxshFCssVdvh_jiOf_C2IyUDDKB9gNz_bt5pLaC8fFmFa0E_Cvq6s9eXOGe8M0fvBUFYG3bqVQAsCyz3w==@protonmail.internalid>
2025-06-17 12:45 ` Pranav Tyagi [this message]
2025-06-30 7:24 ` [PATCH] fs/xfs: replace strncpy with strscpy kernel test robot
2025-06-30 8:38 ` Carlos Maiolino
2025-06-30 9:06 ` Pranav Tyagi
2025-06-30 14:18 ` Brahmajit Das
2025-07-01 8:48 ` Pranav Tyagi
2025-07-01 14:57 ` Darrick J. Wong
2025-07-01 15:42 ` Pranav Tyagi
2025-06-30 18:38 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617124546.24102-1-pranav.tyagi03@gmail.com \
--to=pranav.tyagi03@gmail.com \
--cc=cem@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).