From: Christoph Hellwig <hch@lst.de>
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com,
djwong@kernel.org
Subject: Re: [PATCH 2/2] xfs: kill xlog_in_core_2_t typedef
Date: Tue, 24 Jun 2025 15:59:53 +0200 [thread overview]
Message-ID: <20250624135953.GB24420@lst.de> (raw)
In-Reply-To: <20250620070813.919516-3-cem@kernel.org>
I'm all for killing this typedef, but the name of both the union and the
typedef is just horrible as it describes an on-disk log record.
Maybe replace the union name with something like xlog_rec or xlog_record
first, update the comment above the definiton and only then kill the
typedef?
next prev parent reply other threads:[~2025-06-24 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 7:07 [PATCH 0/2] xfs: iclog small cleanup cem
2025-06-20 7:07 ` [PATCH 1/2] xfs: replace iclogs circular list with a list_head cem
2025-06-24 2:16 ` Dave Chinner
2025-06-24 4:43 ` Carlos Maiolino
2025-06-24 13:57 ` Christoph Hellwig
2025-06-24 18:17 ` Carlos Maiolino
2025-06-25 6:21 ` Christoph Hellwig
2025-06-25 8:20 ` Carlos Maiolino
2025-06-25 11:22 ` Christoph Hellwig
2025-06-20 7:08 ` [PATCH 2/2] xfs: kill xlog_in_core_2_t typedef cem
2025-06-24 13:59 ` Christoph Hellwig [this message]
2025-06-25 8:21 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624135953.GB24420@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).