From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF451291C15 for ; Mon, 30 Jun 2025 16:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751300440; cv=none; b=KdmnXDRQf+nnWd49wvlIIUJ+xfbLyfs3yTFafSMeNAM7ppi9vSAeLqfCLO/3mjjfTgQqSCZGqZnV7ilXp4XLMfvycQIFruC2wgEj4WH88RK2lA1ZTG+V63RoZSfuV23dRhnbI0YyBwzxYIbf41kcnCrlPiXq+xkLo2mO8vyaUFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751300440; c=relaxed/simple; bh=1fmnKQClA+Eq4TXGJEAAeuvdJ0gw1NSpnjK1+MgJX8U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VWOujm2WYd0UfdLHnclQv5fHLl/LdurP8tsx/lEpqTfG5xIoi2nFIyL9FouUu906ucRAeGBt+aC14Fp/vQ6nXSFjR7unCmxNazKF/XTuPm/gGw6W0i/Msjbw/50sRpHYSPnh3J2FOeaoAAlzd7eTEaOBZGNOX+T1+EIZMo+1sh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gzcNb/rV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gzcNb/rV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751300437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=retAznaHagyZVmXo9T/cqkc6BvJhqtSJTEOEchYRx98=; b=gzcNb/rVLruQias5SRzx7tBsEVVBBgrv54jT/226ObQhU6ynbCRGWYuxPsCW+o5XNpNF8B Q9OTTekF8XGdBncE3CWXW/8PVZjrC6nsaluc7kjDSMqvarrLml8piz7TI9/1JM5DPOJ6CU zL315jEPdYTK9+WZedVyTlQqH5mkHmo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-l5y8BrgsOz2DKpdQfgNgFw-1; Mon, 30 Jun 2025 12:20:35 -0400 X-MC-Unique: l5y8BrgsOz2DKpdQfgNgFw-1 X-Mimecast-MFC-AGG-ID: l5y8BrgsOz2DKpdQfgNgFw_1751300434 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450eaae2934so16813365e9.2 for ; Mon, 30 Jun 2025 09:20:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751300434; x=1751905234; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=retAznaHagyZVmXo9T/cqkc6BvJhqtSJTEOEchYRx98=; b=LTJ1l2mmcmxgPn+K/dF3ei4ptBR8lv9EOC3WruOX4YS3aKe/f1jV8tbUayNJXg4H8E 7tRaozQnJ7C/NQbUTB9mYTmX3D/mSmxgSxnp1Wct17U8ubEE2CFcy03evzEOf376Ni7m th6836f7XnSHM/MPOg4hesRFgFXKgP+4FeEI5vSqiHVls9pM89aV55Q0Ro3CXRGFhIHG 23stLjIvgwDkAEAnLmVHuxK3z1xaHfYgr2QMnX4L/H1/dY45FJx+jPpZATNxBYiODtJC BkExquuW8chk4XJ+M8zBS3DSWMPfmxkC6ZQ95ZNz6kldMfHJY7UF3At9W5FsRhh9d4nS QmFA== X-Forwarded-Encrypted: i=1; AJvYcCXiXde+JR8lFgemoAnkcxwZTZHGCe5GThaDZDNkAGv50uSt1lp1SnM6OPlegJmITDJ3XPlq3pMBXrw=@vger.kernel.org X-Gm-Message-State: AOJu0YxcERlaOvHz7N1tfspzeht4q5ecACz3NMzPgiQtYJN3q81xr5Ba s2bng+ttalWpGV9fbpOj6t1qEfCXPAfsTeJ+dNC9BIonDnGiG0eg/OlnC6g2rYE9os2us51go/L WBvjvys/91XnzxfWZcYqhXKevhgGM1RIzBIT8k0bFG1lPN7q6ODC6aflRiTGL X-Gm-Gg: ASbGncs930uZ5M88w4rFVFKVbUf0M7MBScCVQXgNltaRVIihqRx69dciatHuQ54U6oX JS6YEqv88dcDZF+G6LuvKILmBM6S+L6k2puSpi9408mjzsqoB/eRfKZI8qdUwDkmyrTaSaeox4V lLQp1JbtxD0und4oxJfPfKP2GZ1kTHgKTsjy1y3KM229vwqlyDdhLuQnnTIiSvYpI6T86UGp4/J vMrfylccm9qdVVracBZAAJdBKeotVsXGkatgNjDJs8iT04oi7suQU6rz0k4hRM+YASSqKrS/Mbw T70+TqiZCnr/SivhFAQHZomhyjQC X-Received: by 2002:a05:600c:4706:b0:453:8bc7:5e53 with SMTP id 5b1f17b1804b1-4538edf9e08mr161397235e9.0.1751300433917; Mon, 30 Jun 2025 09:20:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGWz29iLt9Ec8/QxCebaTYhDNjHorIH/1Bz8WoGZW+4+aLu8ceqioBoXyyLjXlnzKczI0zmg== X-Received: by 2002:a05:600c:4706:b0:453:8bc7:5e53 with SMTP id 5b1f17b1804b1-4538edf9e08mr161396915e9.0.1751300433504; Mon, 30 Jun 2025 09:20:33 -0700 (PDT) Received: from [127.0.0.2] (ip-217-030-074-039.aim-net.cz. [217.30.74.39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c1easm168769245e9.3.2025.06.30.09.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 09:20:33 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Date: Mon, 30 Jun 2025 18:20:13 +0200 Subject: [PATCH v6 3/6] selinux: implement inode_file_[g|s]etattr hooks Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250630-xattrat-syscall-v6-3-c4e3bc35227b@kernel.org> References: <20250630-xattrat-syscall-v6-0-c4e3bc35227b@kernel.org> In-Reply-To: <20250630-xattrat-syscall-v6-0-c4e3bc35227b@kernel.org> To: Amir Goldstein , Arnd Bergmann , Casey Schaufler , Christian Brauner , Jan Kara , =?utf-8?q?Pali_Roh=C3=A1r?= , Paul Moore Cc: linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, selinux@vger.kernel.org, Andrey Albershteyn X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1658; i=aalbersh@kernel.org; h=from:subject:message-id; bh=1fmnKQClA+Eq4TXGJEAAeuvdJ0gw1NSpnjK1+MgJX8U=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIYMpJ2enPFVZ/teivMYHN62xWL+csXzExLCz/utC+5a qlnSu+es2IdpSwMYlwMsmKKLOuktaYmFUnlHzGokYeZw8oEMoSBi1MAJtLpxfA/JuEJW8yuCy1M T8/dSOzS2vKR9eSE8LZb6+3t7Q8UKSrYMzIsni+mekNPS2F99OTy5xf2ZfnlXYgJXX4lZxPf5md lmZX8AEY/R7U= X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 These hooks are called on inode extended attribute retrieval/change. Cc: selinux@vger.kernel.org Cc: Paul Moore Acked-by: Paul Moore Signed-off-by: Andrey Albershteyn --- security/selinux/hooks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 595ceb314aeb..be7aca2269fa 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -3480,6 +3480,18 @@ static int selinux_inode_removexattr(struct mnt_idmap *idmap, return -EACCES; } +static int selinux_inode_file_setattr(struct dentry *dentry, + struct fileattr *fa) +{ + return dentry_has_perm(current_cred(), dentry, FILE__SETATTR); +} + +static int selinux_inode_file_getattr(struct dentry *dentry, + struct fileattr *fa) +{ + return dentry_has_perm(current_cred(), dentry, FILE__GETATTR); +} + static int selinux_path_notify(const struct path *path, u64 mask, unsigned int obj_type) { @@ -7350,6 +7362,8 @@ static struct security_hook_list selinux_hooks[] __ro_after_init = { LSM_HOOK_INIT(inode_getxattr, selinux_inode_getxattr), LSM_HOOK_INIT(inode_listxattr, selinux_inode_listxattr), LSM_HOOK_INIT(inode_removexattr, selinux_inode_removexattr), + LSM_HOOK_INIT(inode_file_getattr, selinux_inode_file_getattr), + LSM_HOOK_INIT(inode_file_setattr, selinux_inode_file_setattr), LSM_HOOK_INIT(inode_set_acl, selinux_inode_set_acl), LSM_HOOK_INIT(inode_get_acl, selinux_inode_get_acl), LSM_HOOK_INIT(inode_remove_acl, selinux_inode_remove_acl), -- 2.47.2