linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
	song@kernel.org, yukuai3@huawei.com, hch@lst.de,
	nilay@linux.ibm.com, axboe@kernel.dk, cem@kernel.org
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
	ojaswin@linux.ibm.com, martin.petersen@oracle.com,
	akpm@linux-foundation.org, linux-xfs@vger.kernel.org,
	djwong@kernel.org, John Garry <john.g.garry@oracle.com>
Subject: [PATCH v4 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size
Date: Mon,  7 Jul 2025 13:11:29 +0000	[thread overview]
Message-ID: <20250707131135.1572830-1-john.g.garry@oracle.com> (raw)

This value in io_min is used to configure any atomic write limit for the
stacked device. The idea is that the atomic write unit max is a
power-of-2 factor of the stripe size, and the stripe size is available
in io_min.

Using io_min causes issues, as:
a. it may be mutated
b. the check for io_min being set for determining if we are dealing with
a striped device is hard to get right, as reported in [0].

This series now sets chunk_sectors limit to share stripe size.

[0] https://lore.kernel.org/linux-block/888f3b1d-7817-4007-b3b3-1a2ea04df771@linux.ibm.com/T/#mecca17129f72811137d3c2f1e477634e77f06781

Based on 73d9cb37478f (block/for-6.17/block) block: remove pktcdvd driver

This series fixes issues for v6.16, but it's prob better to have this in
v6.17 at this stage.

Differences to v3:
- relocate max_pow_of_two_factor() to common header and rework (Mikulas)
- cater for overflow from chunk sectors (Mikulas)

Differences to v2:
- Add RB tags (thanks!)

Differences to RFC:
- sanitize chunk_sectors for atomic write limits
- set chunk_sectors in stripe_io_hints()

John Garry (6):
  ilog2: add max_pow_of_two_factor()
  block: sanitize chunk_sectors for atomic write limits
  md/raid0: set chunk_sectors limit
  md/raid10: set chunk_sectors limit
  dm-stripe: limit chunk_sectors to the stripe size
  block: use chunk_sectors when evaluating stacked atomic write limits

 block/blk-settings.c   | 66 +++++++++++++++++++++++++++---------------
 drivers/md/dm-stripe.c |  1 +
 drivers/md/raid0.c     |  1 +
 drivers/md/raid10.c    |  1 +
 fs/xfs/xfs_mount.c     |  5 ----
 include/linux/log2.h   | 14 +++++++++
 6 files changed, 60 insertions(+), 28 deletions(-)

-- 
2.43.5


             reply	other threads:[~2025-07-07 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 13:11 John Garry [this message]
2025-07-07 13:11 ` [PATCH v4 1/6] ilog2: add max_pow_of_two_factor() John Garry
2025-07-07 13:11 ` [PATCH v4 2/6] block: sanitize chunk_sectors for atomic write limits John Garry
2025-07-07 13:11 ` [PATCH v4 3/6] md/raid0: set chunk_sectors limit John Garry
2025-07-07 13:11 ` [PATCH v4 4/6] md/raid10: " John Garry
2025-07-07 13:11 ` [PATCH v4 5/6] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-07-07 13:11 ` [PATCH v4 6/6] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-07-08 12:27   ` Nilay Shroff
2025-07-08 12:36     ` John Garry
2025-07-08 16:59     ` Mikulas Patocka
2025-07-08 18:00       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707131135.1572830-1-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).