linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Joanne Koong <joannelkoong@gmail.com>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-block@vger.kernel.org,
	gfs2@lists.linux.dev
Subject: refactor the iomap writeback code v5
Date: Thu, 10 Jul 2025 15:33:24 +0200	[thread overview]
Message-ID: <20250710133343.399917-1-hch@lst.de> (raw)

Hi all,

this is an alternative approach to the writeback part of the
"fuse: use iomap for buffered writes + writeback" series from Joanne.
It doesn't try to make the code build without CONFIG_BLOCK yet.

The big difference compared to Joanne's version is that I hope the
split between the generic and ioend/bio based writeback code is a bit
cleaner here.  We have two methods that define the split between the
generic writeback code, and the implemementation of it, and all knowledge
of ioends and bios now sits below that layer.

This version passes testing on xfs, and gets as far as mainline for
gfs2 (crashes in generic/361).

Changes since v4:
 - add back includes needed in some configs
 - drop an include not needed after a code move

Changes since v3:
 - add a patch to drop unused includes
 - drop the iomap_writepage_ctx renaming - we should do this separately and
   including the variable names if desired
 - add a comment about special casing of holes in iomap_writeback_range
 - split the cleanups to iomap_read_folio_sync into a separate prep patch
 - explain the IOMAP_HOLE check in xfs_iomap_valid
 - explain the iomap_writeback_folio later folio unlock vs dropbehind
 - some cargo culting for the #$W# RST formatting
 - "improve" the documentation coverage a bit

Changes since v2:
 - rename iomap_writepage_ctx to iomap_writeback_ctx
 - keep local map_blocks helpers in XFS
 - allow buildinging the writeback and write code for !CONFIG_BLOCK

Changes since v1:
 - fix iomap reuse in block/zonefs/gfs2 
 - catch too large return value from ->writeback_range
 - mention the correct file name in a commit log
 - add patches for folio laundering
 - add patches for read/modify write in the generic write helpers

Diffstat:
 Documentation/filesystems/iomap/design.rst     |    3 
 Documentation/filesystems/iomap/operations.rst |   57 +-
 block/fops.c                                   |   37 +
 fs/gfs2/aops.c                                 |    8 
 fs/gfs2/bmap.c                                 |   48 +-
 fs/gfs2/bmap.h                                 |    1 
 fs/gfs2/file.c                                 |    3 
 fs/iomap/Makefile                              |    6 
 fs/iomap/buffered-io.c                         |  553 +++++++------------------
 fs/iomap/direct-io.c                           |    5 
 fs/iomap/fiemap.c                              |    3 
 fs/iomap/internal.h                            |    1 
 fs/iomap/ioend.c                               |  220 +++++++++
 fs/iomap/iter.c                                |    1 
 fs/iomap/seek.c                                |    4 
 fs/iomap/swapfile.c                            |    3 
 fs/iomap/trace.c                               |    1 
 fs/iomap/trace.h                               |    4 
 fs/xfs/xfs_aops.c                              |  212 +++++----
 fs/xfs/xfs_file.c                              |    6 
 fs/xfs/xfs_iomap.c                             |   12 
 fs/xfs/xfs_iomap.h                             |    1 
 fs/xfs/xfs_reflink.c                           |    3 
 fs/zonefs/file.c                               |   40 +
 include/linux/iomap.h                          |   82 ++-
 25 files changed, 705 insertions(+), 609 deletions(-)

             reply	other threads:[~2025-07-10 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 13:33 Christoph Hellwig [this message]
2025-07-10 13:33 ` [PATCH 01/14] iomap: header diet Christoph Hellwig
2025-07-10 13:33 ` [PATCH 02/14] iomap: pass more arguments using the iomap writeback context Christoph Hellwig
2025-07-10 13:33 ` [PATCH 03/14] iomap: cleanup the pending writeback tracking in iomap_writepage_map_blocks Christoph Hellwig
2025-07-10 13:33 ` [PATCH 04/14] iomap: refactor the writeback interface Christoph Hellwig
2025-07-10 13:33 ` [PATCH 05/14] iomap: hide ioends from the generic writeback code Christoph Hellwig
2025-07-10 13:33 ` [PATCH 06/14] iomap: add public helpers for uptodate state manipulation Christoph Hellwig
2025-07-10 13:33 ` [PATCH 07/14] iomap: move all ioend handling to ioend.c Christoph Hellwig
2025-07-10 13:33 ` [PATCH 08/14] iomap: rename iomap_writepage_map to iomap_writeback_folio Christoph Hellwig
2025-07-10 13:33 ` [PATCH 09/14] iomap: move folio_unlock out of iomap_writeback_folio Christoph Hellwig
2025-07-10 13:33 ` [PATCH 10/14] iomap: export iomap_writeback_folio Christoph Hellwig
2025-07-10 13:33 ` [PATCH 11/14] iomap: replace iomap_folio_ops with iomap_write_ops Christoph Hellwig
2025-07-10 13:33 ` [PATCH 12/14] iomap: improve argument passing to iomap_read_folio_sync Christoph Hellwig
2025-07-10 13:33 ` [PATCH 13/14] iomap: add read_folio_range() handler for buffered writes Christoph Hellwig
2025-07-10 13:33 ` [PATCH 14/14] iomap: build the writeback code without CONFIG_BLOCK Christoph Hellwig
2025-07-11  9:50 ` refactor the iomap writeback code v5 Christian Brauner
2025-07-11 11:20   ` Christoph Hellwig
2025-07-14  8:52 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250710133343.399917-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=gfs2@lists.linux.dev \
    --cc=joannelkoong@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).