Re: [PATCH 1/8] xfs: use xfs_trans_reserve_more in xfs_trans_reserve_more_inode

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jul 15, 2025 at 02:25:34PM +0200, Christoph Hellwig wrote:
> Instead of duplicating the empty transacaction reservation
> definition.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Nice cleanup
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_trans.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
> index b4a07af513ba..8b15bfe68774 100644
> --- a/fs/xfs/xfs_trans.c
> +++ b/fs/xfs/xfs_trans.c
> @@ -1163,14 +1163,13 @@ xfs_trans_reserve_more_inode(
>  	unsigned int		rblocks,
>  	bool			force_quota)
>  {
> -	struct xfs_trans_res	resv = { };
>  	struct xfs_mount	*mp = ip->i_mount;
>  	unsigned int		rtx = xfs_extlen_to_rtxlen(mp, rblocks);
>  	int			error;
>  
>  	xfs_assert_ilocked(ip, XFS_ILOCK_EXCL);
>  
> -	error = xfs_trans_reserve(tp, &resv, dblocks, rtx);
> +	error = xfs_trans_reserve_more(tp, dblocks, rtx);
>  	if (error)
>  		return error;
>  
> -- 
> 2.47.2
> 
>