Re: [PATCH 7/7] xfs: improve the comments in xfs_select_zone_nowait

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jul 16, 2025 at 02:54:07PM +0200, Christoph Hellwig wrote:
> The top of the function comment is outdated, and the parts still correct
> duplicate information in comment inside the function.  Remove the top of
> the function comment and instead improve a comment inside the function.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Makes sense,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_zone_alloc.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
> index c1f053f4a82a..4e4ca5bbfc47 100644
> --- a/fs/xfs/xfs_zone_alloc.c
> +++ b/fs/xfs/xfs_zone_alloc.c
> @@ -654,13 +654,6 @@ static inline bool xfs_zoned_pack_tight(struct xfs_inode *ip)
>  		!(ip->i_diflags & XFS_DIFLAG_APPEND);
>  }
>  
> -/*
> - * Pick a new zone for writes.
> - *
> - * If we aren't using up our budget of open zones just open a new one from the
> - * freelist.  Else try to find one that matches the expected data lifetime.  If
> - * we don't find one that is good pick any zone that is available.
> - */
>  static struct xfs_open_zone *
>  xfs_select_zone_nowait(
>  	struct xfs_mount	*mp,
> @@ -688,7 +681,8 @@ xfs_select_zone_nowait(
>  		goto out_unlock;
>  
>  	/*
> -	 * See if we can open a new zone and use that.
> +	 * See if we can open a new zone and use that so that data for different
> +	 * files is mixed as little as possible.
>  	 */
>  	oz = xfs_try_open_zone(mp, write_hint);
>  	if (oz)
> -- 
> 2.47.2
> 
>