linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: cen zhang <zzzccc427@gmail.com>, linux-xfs@vger.kernel.org
Subject: fix XFS_IBULK_* vs XFS_IWALK_* confusion
Date: Wed, 23 Jul 2025 14:19:43 +0200	[thread overview]
Message-ID: <20250723122011.3178474-1-hch@lst.de> (raw)

Hi all,

this fixes a syzcall triggered assert due to the somewhat sloppy split
between the XFS_IBULK and XFS_IWALK flags.  The first is the minimal
fix for the reported problem, and the second one cleans up the
interface to avoid problems like this in the future.

Diffstat:
 xfs_ioctl.c  |    2 +-
 xfs_itable.c |    8 ++------
 xfs_itable.h |   10 ++++------
 3 files changed, 7 insertions(+), 13 deletions(-)

             reply	other threads:[~2025-07-23 12:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 12:19 Christoph Hellwig [this message]
2025-07-23 12:19 ` [PATCH 1/2] xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags Christoph Hellwig
2025-07-23 16:20   ` Darrick J. Wong
2025-08-05  9:23     ` Carlos Maiolino
2025-07-23 12:19 ` [PATCH 2/2] xfs: remove XFS_IBULK_SAME_AG Christoph Hellwig
2025-07-23 16:21   ` Darrick J. Wong
2025-08-12  7:33 ` fix XFS_IBULK_* vs XFS_IWALK_* confusion Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250723122011.3178474-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).