From: "Darrick J. Wong" <djwong@kernel.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/3] Use new syscalls to set filesystem inode attributes on any inode
Date: Tue, 29 Jul 2025 08:52:05 -0700 [thread overview]
Message-ID: <20250729155205.GF2672070@frogsfrogsfrogs> (raw)
In-Reply-To: <5jw4nzpg26faxkzyeo3n2yczqxjczyq5c7qukfvqkx5e254m4k@tafsr7bdstcd>
On Tue, Jul 29, 2025 at 05:50:08PM +0200, Andrey Albershteyn wrote:
> On 2025-07-29 07:34:11, Darrick J. Wong wrote:
> > On Tue, Jul 29, 2025 at 01:00:34PM +0200, Andrey Albershteyn wrote:
> > > With addition of new syscalls file_getattr/file_setattr allow changing
> > > filesystem inode attributes on special files. Fix project ID inheritance
> > > for special files in renames.
> > >
> > > Cc: linux-xfs@vger.kernel.org
> > >
> > > ---
> > > Darrick, I left your reviewed-by tags, as the code didn't changed, I just
> > > updated the commit messages. Let me know if you have any new feedback on
> > > this.
> >
> > It all looks ok except for s/(file| )extended attribute/fileattr/
> >
> > Seeing as the VFS part just went in for 6.17 this should probably get
> > merged soonish, right?
>
> Without this special files won't be able to use these syscalls, but
> otherwise, for regular files nothing changes. So, I think it not
> necessary for this to get into this merge window.
<nod> Ok.
--D
> >
> > --D
> >
> > > ---
> > > Andrey Albershteyn (3):
> > > xfs: allow renames of project-less inodes
> > > xfs: allow setting xattrs on special files
> > > xfs: add .fileattr_set and fileattr_get callbacks for symlinks
> > >
> > > fs/xfs/xfs_inode.c | 64 +++++++++++++++++++++++++++++-------------------------
> > > fs/xfs/xfs_ioctl.c | 6 -----
> > > fs/xfs/xfs_iops.c | 2 ++
> > > 3 files changed, 36 insertions(+), 36 deletions(-)
> > > ---
> > > base-commit: 86aa721820952b793a12fc6e5a01734186c0c238
> > > change-id: 20250320-xfs-xattrat-b31a9f5ed284
> > >
> > > Best regards,
> > > --
> > > Andrey Albershteyn <aalbersh@kernel.org>
> > >
> > >
> >
>
> --
> - Andrey
>
prev parent reply other threads:[~2025-07-29 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 11:00 [PATCH 0/3] Use new syscalls to set filesystem inode attributes on any inode Andrey Albershteyn
2025-07-29 11:00 ` [PATCH 1/3] xfs: allow renames of project-less inodes Andrey Albershteyn
2025-07-29 11:00 ` [PATCH 2/3] xfs: allow setting xattrs on special files Andrey Albershteyn
2025-07-29 14:32 ` Darrick J. Wong
2025-07-29 14:55 ` Andrey Albershteyn
2025-07-29 11:00 ` [PATCH 3/3] xfs: add .fileattr_set and fileattr_get callbacks for symlinks Andrey Albershteyn
2025-07-29 14:34 ` [PATCH 0/3] Use new syscalls to set filesystem inode attributes on any inode Darrick J. Wong
2025-07-29 15:50 ` Andrey Albershteyn
2025-07-29 15:52 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729155205.GF2672070@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@redhat.com \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox