From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] xfs: fix frozen file system assert in xfs_trans_alloc
Date: Thu, 31 Jul 2025 10:04:03 -0700 [thread overview]
Message-ID: <20250731170403.GI2672070@frogsfrogsfrogs> (raw)
In-Reply-To: <20250731161558.GA10215@lst.de>
On Thu, Jul 31, 2025 at 06:15:58PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 31, 2025 at 08:59:41AM -0700, Darrick J. Wong wrote:
> > > retry:
> > > - WARN_ON(mp->m_super->s_writers.frozen == SB_FREEZE_COMPLETE);
> > > tp = __xfs_trans_alloc(mp, flags);
> > > + WARN_ON(mp->m_super->s_writers.frozen == SB_FREEZE_COMPLETE);
> >
> > Empty transactions can run during a freeze, so please put back the
> > original warning and comment:
>
> Empty transactions don't end up in this code path any more.
Oh, hah, silly me, I forgot that also got changed by that patchset. :(
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
next prev parent reply other threads:[~2025-07-31 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 14:19 [PATCH] xfs: fix frozen file system assert in xfs_trans_alloc Christoph Hellwig
2025-07-31 15:59 ` Darrick J. Wong
2025-07-31 16:15 ` Christoph Hellwig
2025-07-31 17:04 ` Darrick J. Wong [this message]
2025-08-12 7:33 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731170403.GI2672070@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox