linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xfs: fix scrub trace with null pointer in quotacheck
@ 2025-07-31 17:07 Andrey Albershteyn
  2025-08-12  7:33 ` Carlos Maiolino
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Albershteyn @ 2025-07-31 17:07 UTC (permalink / raw)
  To: linux-xfs, cem; +Cc: djwong, Andrey Albershteyn, stable

The quotacheck doesn't initialize sc->ip.

Cc: <stable@vger.kernel.org> # v6.8
Fixes: 21d7500929c8a0 ("xfs: improve dquot iteration for scrub")
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 fs/xfs/scrub/trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/scrub/trace.h b/fs/xfs/scrub/trace.h
index 1e6e9c10cea2..a8187281eb96 100644
--- a/fs/xfs/scrub/trace.h
+++ b/fs/xfs/scrub/trace.h
@@ -479,7 +479,7 @@ DECLARE_EVENT_CLASS(xchk_dqiter_class,
 		__field(xfs_exntst_t, state)
 	),
 	TP_fast_assign(
-		__entry->dev = cursor->sc->ip->i_mount->m_super->s_dev;
+		__entry->dev = cursor->sc->mp->m_super->s_dev;
 		__entry->dqtype = cursor->dqtype;
 		__entry->ino = cursor->quota_ip->i_ino;
 		__entry->cur_id = cursor->id;
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs: fix scrub trace with null pointer in quotacheck
  2025-07-31 17:07 [PATCH] xfs: fix scrub trace with null pointer in quotacheck Andrey Albershteyn
@ 2025-08-12  7:33 ` Carlos Maiolino
  0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2025-08-12  7:33 UTC (permalink / raw)
  To: linux-xfs, Andrey Albershteyn; +Cc: djwong, Andrey Albershteyn, stable

On Thu, 31 Jul 2025 19:07:22 +0200, Andrey Albershteyn wrote:
> The quotacheck doesn't initialize sc->ip.
> 
> 

Applied to for-next, thanks!

[1/1] xfs: fix scrub trace with null pointer in quotacheck
      commit: 5d94b19f066480addfcdcb5efde66152ad5a7c0e

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-12  7:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-31 17:07 [PATCH] xfs: fix scrub trace with null pointer in quotacheck Andrey Albershteyn
2025-08-12  7:33 ` Carlos Maiolino

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).