From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: implement XFS_IOC_DIOINFO in terms of vfs_getattr
Date: Thu, 21 Aug 2025 10:40:37 +0200 [thread overview]
Message-ID: <20250821084037.GA29746@lst.de> (raw)
In-Reply-To: <bcwk3ezkikdmkgisfhukyxk3ojtkmbeonnepaxt3pmzof662b6@iddfobua7bme>
On Wed, Aug 20, 2025 at 10:23:27AM +0200, Carlos Maiolino wrote:
> Do we need to keep this comment that tied to an userspace tool?
It think it is a pretty good reminder why it is here.
> The issue with randholes is that it uses posix_memalign, and the pointer
> size constraint comes from that.
>
> I couldn't find any details on why this is required, but I'm assuming
> it's to keep posix_memalign architecture/implementation independent?!
>
> So, perhaps instead of being 'randholes' specific, it should specify to
> be posix compliant or because posix requires this way?
Posix does not require the alignment to be larger than void *.
Applications that directly feed the value to posix_memalign do.
And maybe that what could go into the comment.
next prev parent reply other threads:[~2025-08-21 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9aG8Tf3X2d-4A9_uy7q50gPfuQH-xjOf3Bdbw4mJ5ITHbBXXDwYG2uqAYoSKE-pRy5iYgqRbd79paOGW-Sk_SA==@protonmail.internalid>
2025-08-18 5:13 ` [PATCH] xfs: implement XFS_IOC_DIOINFO in terms of vfs_getattr Christoph Hellwig
2025-08-18 20:47 ` Darrick J. Wong
2025-08-20 8:23 ` Carlos Maiolino
2025-08-21 8:40 ` Christoph Hellwig [this message]
2025-08-21 10:59 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821084037.GA29746@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).