From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 8/9] xfs: remove static reap limits
Date: Wed, 3 Sep 2025 08:03:11 +0200 [thread overview]
Message-ID: <20250903060311.GB10069@lst.de> (raw)
In-Reply-To: <20250902223203.GJ8096@frogsfrogsfrogs>
On Tue, Sep 02, 2025 at 03:32:03PM -0700, Darrick J. Wong wrote:
> It's only needed in newbt.c. What if I change the commit message to:
>
> "xfs: remove static reap limits from repair.h
>
> "Delete XREAP_MAX_BINVAL and XREAP_MAX_DEFER_CHAIN because the reap code
> now calculates those limits dynamically, so they're no longer needed.
>
> "Move the third limit (XREP_MAX_ITRUNCATE_EFIS) to the one file that
> uses it. Note that the btree rebuilding code should reserve exactly the
> number of blocks needed to rebuild a btree, so it is rare that the newbt
> code will need to add any EFIs to the commit transaction. That's why
> that static limit remains."
>
> Would that make it clearer?
Yes. With that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-09-03 6:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 14:28 [PATCHSET] xfs: improve online repair reap calculations Darrick J. Wong
2025-08-28 14:28 ` [PATCH 1/9] xfs: prepare reaping code for dynamic limits Darrick J. Wong
2025-09-02 6:23 ` Christoph Hellwig
2025-08-28 14:28 ` [PATCH 2/9] xfs: convert the ifork reap code to use xreap_state Darrick J. Wong
2025-09-02 6:24 ` Christoph Hellwig
2025-08-28 14:28 ` [PATCH 3/9] xfs: use deferred intent items for reaping crosslinked blocks Darrick J. Wong
2025-09-02 6:25 ` Christoph Hellwig
2025-09-02 22:22 ` Darrick J. Wong
2025-08-28 14:28 ` [PATCH 4/9] xfs: compute per-AG extent reap limits dynamically Darrick J. Wong
2025-09-02 6:26 ` Christoph Hellwig
2025-08-28 14:29 ` [PATCH 5/9] xfs: compute data device CoW staging " Darrick J. Wong
2025-09-03 6:02 ` Christoph Hellwig
2025-08-28 14:29 ` [PATCH 6/9] xfs: compute realtime " Darrick J. Wong
2025-09-02 6:27 ` Christoph Hellwig
2025-08-28 14:29 ` [PATCH 7/9] xfs: compute file mapping " Darrick J. Wong
2025-09-02 6:27 ` Christoph Hellwig
2025-08-28 14:29 ` [PATCH 8/9] xfs: remove static reap limits Darrick J. Wong
2025-09-02 6:28 ` Christoph Hellwig
2025-09-02 22:32 ` Darrick J. Wong
2025-09-03 6:03 ` Christoph Hellwig [this message]
2025-09-03 6:27 ` Darrick J. Wong
2025-08-28 14:30 ` [PATCH 9/9] xfs: use deferred reaping for data device cow extents Darrick J. Wong
2025-09-02 6:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903060311.GB10069@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).