Re: [PATCH 4/4] xfs: enable online fsck by default in Kconfig

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Sep 03, 2025 at 08:07:29PM +0200, Vlastimil Babka wrote:
> On 9/3/25 17:00, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Online fsck has been a part of upstream for over a year now without any
> > serious problems.  Turn it on by default in time for the 2025 LTS
> > kernel.
> > 
> > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> > ---
> >  fs/xfs/Kconfig |    8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > 
> > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> > index ecebd3ebab1342..dc55bbf295208d 100644
> > --- a/fs/xfs/Kconfig
> > +++ b/fs/xfs/Kconfig
> > @@ -137,7 +137,7 @@ config XFS_BTREE_IN_MEM
> >  
> >  config XFS_ONLINE_SCRUB
> >  	bool "XFS online metadata check support"
> > -	default n
> > +	default y
> >  	depends on XFS_FS
> >  	depends on TMPFS && SHMEM
> >  	select XFS_LIVE_HOOKS
> > @@ -150,8 +150,6 @@ config XFS_ONLINE_SCRUB
> >  	  advantage here is to look for problems proactively so that
> >  	  they can be dealt with in a controlled manner.
> >  
> > -	  This feature is considered EXPERIMENTAL.  Use with caution!
> > -
> >  	  See the xfs_scrub man page in section 8 for additional information.
> >  
> >  	  If unsure, say N.
> 
> Should it still say that with default y?

I suppose not. :D

--D

> > @@ -175,7 +173,7 @@ config XFS_ONLINE_SCRUB_STATS
> >  
> >  config XFS_ONLINE_REPAIR
> >  	bool "XFS online metadata repair support"
> > -	default n
> > +	default y
> >  	depends on XFS_FS && XFS_ONLINE_SCRUB
> >  	select XFS_BTREE_IN_MEM
> >  	help
> > @@ -186,8 +184,6 @@ config XFS_ONLINE_REPAIR
> >  	  formatted with secondary metadata, such as reverse mappings and inode
> >  	  parent pointers.
> >  
> > -	  This feature is considered EXPERIMENTAL.  Use with caution!
> > -
> >  	  See the xfs_scrub man page in section 8 for additional information.
> >  
> >  	  If unsure, say N.
> 
> Ditto
>