Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 02/15] xfs: remove the xfs_trans_header_t typedef
Date: Mon, 15 Sep 2025 06:26:52 -0700	[thread overview]
Message-ID: <20250915132709.160247-3-hch@lst.de> (raw)
In-Reply-To: <20250915132709.160247-1-hch@lst.de>

There are almost no users of the typedef left, kill it and switch the
remaining users to use the underlying struct.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/xfs/libxfs/xfs_log_format.h  | 4 ++--
 fs/xfs/libxfs/xfs_log_recover.h | 2 +-
 fs/xfs/xfs_log.c                | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
index e6070ad72af4..8f208e93ec3b 100644
--- a/fs/xfs/libxfs/xfs_log_format.h
+++ b/fs/xfs/libxfs/xfs_log_format.h
@@ -203,12 +203,12 @@ typedef struct xfs_log_iovec {
  * Do not change the below structure without redoing the code in
  * xlog_recover_add_to_trans() and xlog_recover_add_to_cont_trans().
  */
-typedef struct xfs_trans_header {
+struct xfs_trans_header {
 	uint		th_magic;		/* magic number */
 	uint		th_type;		/* transaction type */
 	int32_t		th_tid;			/* transaction id (unused) */
 	uint		th_num_items;		/* num items logged by trans */
-} xfs_trans_header_t;
+};
 
 #define	XFS_TRANS_HEADER_MAGIC	0x5452414e	/* TRAN */
 
diff --git a/fs/xfs/libxfs/xfs_log_recover.h b/fs/xfs/libxfs/xfs_log_recover.h
index 95de23095030..9e712e62369c 100644
--- a/fs/xfs/libxfs/xfs_log_recover.h
+++ b/fs/xfs/libxfs/xfs_log_recover.h
@@ -111,7 +111,7 @@ struct xlog_recover_item {
 struct xlog_recover {
 	struct hlist_node	r_list;
 	xlog_tid_t		r_log_tid;	/* log's transaction id */
-	xfs_trans_header_t	r_theader;	/* trans header for partial */
+	struct xfs_trans_header	r_theader;	/* trans header for partial */
 	int			r_state;	/* not needed */
 	xfs_lsn_t		r_lsn;		/* xact lsn */
 	struct list_head	r_itemq;	/* q for items */
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 354e8e0114a6..2978de9da38e 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -3155,7 +3155,7 @@ xlog_calc_unit_res(
 
 	/* for trans header */
 	unit_bytes += sizeof(struct xlog_op_header);
-	unit_bytes += sizeof(xfs_trans_header_t);
+	unit_bytes += sizeof(struct xfs_trans_header);
 
 	/* for start-rec */
 	unit_bytes += sizeof(struct xlog_op_header);
-- 
2.47.2


  parent reply	other threads:[~2025-09-15 13:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 13:26 remove most typedefs from xfs_log_format.h Christoph Hellwig
2025-09-15 13:26 ` [PATCH 01/15] xfs: remove the xlog_op_header_t typedef Christoph Hellwig
2025-09-15 13:26 ` Christoph Hellwig [this message]
2025-09-15 13:26 ` [PATCH 03/15] xfs: remove the xfs_extent_t typedef Christoph Hellwig
2025-09-15 13:26 ` [PATCH 04/15] xfs: remove the xfs_extent32_t typedef Christoph Hellwig
2025-09-15 13:26 ` [PATCH 05/15] xfs: remove the xfs_extent64_t typedef Christoph Hellwig
2025-09-15 13:26 ` [PATCH 06/15] xfs: remove the xfs_efi_log_format_t typedef Christoph Hellwig
2025-09-15 13:26 ` [PATCH 07/15] xfs: remove the xfs_efi_log_format_32_t typedef Christoph Hellwig
2025-09-15 13:26 ` [PATCH 08/15] xfs: remove the xfs_efi_log_format_64_t typedef Christoph Hellwig
2025-09-15 13:26 ` [PATCH 09/15] xfs: remove the xfs_efd_log_format_t typedef Christoph Hellwig
2025-09-15 13:27 ` [PATCH 10/15] xfs: remove the unused xfs_efd_log_format_32_t typedef Christoph Hellwig
2025-09-15 13:27 ` [PATCH 11/15] xfs: remove the unused xfs_efd_log_format_64_t typedef Christoph Hellwig
2025-09-15 13:27 ` [PATCH 12/15] xfs: remove the unused xfs_buf_log_format_t typedef Christoph Hellwig
2025-09-15 13:27 ` [PATCH 13/15] xfs: remove the unused xfs_dq_logformat_t typedef Christoph Hellwig
2025-09-15 13:27 ` [PATCH 14/15] xfs: remove the unused xfs_qoff_logformat_t typedef Christoph Hellwig
2025-09-15 13:27 ` [PATCH 15/15] xfs: remove the unused xfs_log_iovec_t typedef Christoph Hellwig
2025-09-15 18:29 ` remove most typedefs from xfs_log_format.h Darrick J. Wong
2025-09-16 11:34 ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250915132709.160247-3-hch@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox