From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: move the XLOG_REG_ constants out of xfs_log_format.h
Date: Mon, 15 Sep 2025 11:27:32 -0700 [thread overview]
Message-ID: <20250915182732.GR8096@frogsfrogsfrogs> (raw)
In-Reply-To: <20250915132413.159877-1-hch@lst.de>
On Mon, Sep 15, 2025 at 06:24:13AM -0700, Christoph Hellwig wrote:
> These are purely in-memory values and not used at all in xfsprogs.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok, but why not move struct xfs_log_iovec as well? It's also not
part of the ondisk log format.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_log_format.h | 37 ----------------------------------
> fs/xfs/xfs_log.h | 37 ++++++++++++++++++++++++++++++++++
> 2 files changed, 37 insertions(+), 37 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
> index 942c490f23e4..890646b5c87a 100644
> --- a/fs/xfs/libxfs/xfs_log_format.h
> +++ b/fs/xfs/libxfs/xfs_log_format.h
> @@ -86,43 +86,6 @@ struct xfs_unmount_log_format {
> uint32_t pad2; /* may as well make it 64 bits */
> };
>
> -/* Region types for iovec's i_type */
> -#define XLOG_REG_TYPE_BFORMAT 1
> -#define XLOG_REG_TYPE_BCHUNK 2
> -#define XLOG_REG_TYPE_EFI_FORMAT 3
> -#define XLOG_REG_TYPE_EFD_FORMAT 4
> -#define XLOG_REG_TYPE_IFORMAT 5
> -#define XLOG_REG_TYPE_ICORE 6
> -#define XLOG_REG_TYPE_IEXT 7
> -#define XLOG_REG_TYPE_IBROOT 8
> -#define XLOG_REG_TYPE_ILOCAL 9
> -#define XLOG_REG_TYPE_IATTR_EXT 10
> -#define XLOG_REG_TYPE_IATTR_BROOT 11
> -#define XLOG_REG_TYPE_IATTR_LOCAL 12
> -#define XLOG_REG_TYPE_QFORMAT 13
> -#define XLOG_REG_TYPE_DQUOT 14
> -#define XLOG_REG_TYPE_QUOTAOFF 15
> -#define XLOG_REG_TYPE_LRHEADER 16
> -#define XLOG_REG_TYPE_UNMOUNT 17
> -#define XLOG_REG_TYPE_COMMIT 18
> -#define XLOG_REG_TYPE_TRANSHDR 19
> -#define XLOG_REG_TYPE_ICREATE 20
> -#define XLOG_REG_TYPE_RUI_FORMAT 21
> -#define XLOG_REG_TYPE_RUD_FORMAT 22
> -#define XLOG_REG_TYPE_CUI_FORMAT 23
> -#define XLOG_REG_TYPE_CUD_FORMAT 24
> -#define XLOG_REG_TYPE_BUI_FORMAT 25
> -#define XLOG_REG_TYPE_BUD_FORMAT 26
> -#define XLOG_REG_TYPE_ATTRI_FORMAT 27
> -#define XLOG_REG_TYPE_ATTRD_FORMAT 28
> -#define XLOG_REG_TYPE_ATTR_NAME 29
> -#define XLOG_REG_TYPE_ATTR_VALUE 30
> -#define XLOG_REG_TYPE_XMI_FORMAT 31
> -#define XLOG_REG_TYPE_XMD_FORMAT 32
> -#define XLOG_REG_TYPE_ATTR_NEWNAME 33
> -#define XLOG_REG_TYPE_ATTR_NEWVALUE 34
> -#define XLOG_REG_TYPE_MAX 34
> -
> /*
> * Flags to log operation header
> *
> diff --git a/fs/xfs/xfs_log.h b/fs/xfs/xfs_log.h
> index af6daf4f6792..dcc1f44ed68f 100644
> --- a/fs/xfs/xfs_log.h
> +++ b/fs/xfs/xfs_log.h
> @@ -20,6 +20,43 @@ struct xfs_log_vec {
> int lv_alloc_size; /* size of allocated lv */
> };
>
> +/* Region types for iovec's i_type */
> +#define XLOG_REG_TYPE_BFORMAT 1
> +#define XLOG_REG_TYPE_BCHUNK 2
> +#define XLOG_REG_TYPE_EFI_FORMAT 3
> +#define XLOG_REG_TYPE_EFD_FORMAT 4
> +#define XLOG_REG_TYPE_IFORMAT 5
> +#define XLOG_REG_TYPE_ICORE 6
> +#define XLOG_REG_TYPE_IEXT 7
> +#define XLOG_REG_TYPE_IBROOT 8
> +#define XLOG_REG_TYPE_ILOCAL 9
> +#define XLOG_REG_TYPE_IATTR_EXT 10
> +#define XLOG_REG_TYPE_IATTR_BROOT 11
> +#define XLOG_REG_TYPE_IATTR_LOCAL 12
> +#define XLOG_REG_TYPE_QFORMAT 13
> +#define XLOG_REG_TYPE_DQUOT 14
> +#define XLOG_REG_TYPE_QUOTAOFF 15
> +#define XLOG_REG_TYPE_LRHEADER 16
> +#define XLOG_REG_TYPE_UNMOUNT 17
> +#define XLOG_REG_TYPE_COMMIT 18
> +#define XLOG_REG_TYPE_TRANSHDR 19
> +#define XLOG_REG_TYPE_ICREATE 20
> +#define XLOG_REG_TYPE_RUI_FORMAT 21
> +#define XLOG_REG_TYPE_RUD_FORMAT 22
> +#define XLOG_REG_TYPE_CUI_FORMAT 23
> +#define XLOG_REG_TYPE_CUD_FORMAT 24
> +#define XLOG_REG_TYPE_BUI_FORMAT 25
> +#define XLOG_REG_TYPE_BUD_FORMAT 26
> +#define XLOG_REG_TYPE_ATTRI_FORMAT 27
> +#define XLOG_REG_TYPE_ATTRD_FORMAT 28
> +#define XLOG_REG_TYPE_ATTR_NAME 29
> +#define XLOG_REG_TYPE_ATTR_VALUE 30
> +#define XLOG_REG_TYPE_XMI_FORMAT 31
> +#define XLOG_REG_TYPE_XMD_FORMAT 32
> +#define XLOG_REG_TYPE_ATTR_NEWNAME 33
> +#define XLOG_REG_TYPE_ATTR_NEWVALUE 34
> +#define XLOG_REG_TYPE_MAX 34
> +
> #define XFS_LOG_VEC_ORDERED (-1)
>
> /*
> --
> 2.47.2
>
>
next prev parent reply other threads:[~2025-09-15 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 13:24 [PATCH] xfs: move the XLOG_REG_ constants out of xfs_log_format.h Christoph Hellwig
2025-09-15 18:27 ` Darrick J. Wong [this message]
2025-09-15 20:48 ` Christoph Hellwig
2025-09-16 14:01 ` Christoph Hellwig
2025-09-16 14:42 ` Darrick J. Wong
2025-09-19 16:15 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915182732.GR8096@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).