From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: fix log CRC mismatches between i386 and other architectures
Date: Mon, 15 Sep 2025 22:50:49 +0200 [thread overview]
Message-ID: <20250915205049.GB5650@lst.de> (raw)
In-Reply-To: <20250915182513.GP8096@frogsfrogsfrogs>
On Mon, Sep 15, 2025 at 11:25:13AM -0700, Darrick J. Wong wrote:
> ...and let me guess, the checksum function samples data all the way out
> to byte 324/328 too?
Yes.
> > Fixes: 0e446be44806 ("xfs: add CRC checks to the log")
>
> Cc: <stable@vger.kernel.org> # v3.8
Still not a fan of the explicit stable tag vs implying it by fixes,
but yes, this should be backported.
> > + * We now do two checksum validation passes for both sizes to allow
> > + * moving v5 file systems with unclean logs between i386 and other
> > + * (little-endian) architectures.
>
> Is this a problem on other 32-bit platforms? Or just i386?
The alignment is an i386-specific quirk. We have similar workarounds
for the extent structure in the EFI/EFD items and some 32-bit ioctls,
except that this one can be a bit simpler.
next prev parent reply other threads:[~2025-09-15 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 13:20 fix cross-platform log CRC validation Christoph Hellwig
2025-09-15 13:20 ` [PATCH 1/2] xfs: rename the old_crc variable in xlog_recover_process Christoph Hellwig
2025-09-15 18:25 ` Darrick J. Wong
2025-09-15 13:20 ` [PATCH 2/2] xfs: fix log CRC mismatches between i386 and other architectures Christoph Hellwig
2025-09-15 18:25 ` Darrick J. Wong
2025-09-15 20:50 ` Christoph Hellwig [this message]
2025-09-16 10:26 ` Carlos Maiolino
2025-09-16 11:34 ` fix cross-platform log CRC validation Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915205049.GB5650@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox