From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: move the XLOG_REG_ constants out of xfs_log_format.h
Date: Tue, 16 Sep 2025 16:01:09 +0200 [thread overview]
Message-ID: <20250916140109.GA919@lst.de> (raw)
In-Reply-To: <20250915204835.GA5650@lst.de>
On Mon, Sep 15, 2025 at 10:48:35PM +0200, Christoph Hellwig wrote:
> On Mon, Sep 15, 2025 at 11:27:32AM -0700, Darrick J. Wong wrote:
> > On Mon, Sep 15, 2025 at 06:24:13AM -0700, Christoph Hellwig wrote:
> > > These are purely in-memory values and not used at all in xfsprogs.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Looks ok, but why not move struct xfs_log_iovec as well? It's also not
> > part of the ondisk log format.
>
> I have a separate series that includes the move, but I might as well
> send that now.
I just looked into that: with my log formatting clean series,
xfs_log_iovec can and should move to xfs_log_priv.h, while right now
we could only move it to xfs_log.h. So I'd rather not move it twice
and wait a bit.
next prev parent reply other threads:[~2025-09-16 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 13:24 [PATCH] xfs: move the XLOG_REG_ constants out of xfs_log_format.h Christoph Hellwig
2025-09-15 18:27 ` Darrick J. Wong
2025-09-15 20:48 ` Christoph Hellwig
2025-09-16 14:01 ` Christoph Hellwig [this message]
2025-09-16 14:42 ` Darrick J. Wong
2025-09-19 16:15 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916140109.GA919@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).