From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: don't use __GFP_NOFAIL in xfs_init_fs_context
Date: Fri, 3 Oct 2025 09:58:51 +0200 [thread overview]
Message-ID: <20251003075851.GC13238@lst.de> (raw)
In-Reply-To: <20250929183437.GB8096@frogsfrogsfrogs>
On Mon, Sep 29, 2025 at 11:34:37AM -0700, Darrick J. Wong wrote:
> On Mon, Sep 29, 2025 at 08:41:54AM +0200, Christoph Hellwig wrote:
> > xfs_init_fs_context is early in the mount process, and if we really
> > are out of memory there we'd better give up ASAP.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Is this the fix for that recent sysbot report? If so, maybe you ought
> to link to the syzbot thread:
> Link: https://lore.kernel.org/linux-xfs/3d54a546-77dd-4913-bcd0-7472aec8f53c@suse.cz/T/#md6876fda5ae060700801623ee18fa59317c5cbc4
At least if my theory there was correct the bug is in the mm code and
it doesn't actually fix the bug, it just removes one way to trigger it.
> In any case the logic is sound and it's quite easy to bloat xfs_mount
> to be larger than 4k so the kzalloc is simply fallible:
If OTOH your theory here is correct, it does fix the bug. Let me check
their .config to see which theory is correct.
prev parent reply other threads:[~2025-10-03 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 6:41 [PATCH] xfs: don't use __GFP_NOFAIL in xfs_init_fs_context Christoph Hellwig
2025-09-29 18:34 ` Darrick J. Wong
2025-10-03 7:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003075851.GC13238@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).